From 6f4e38d129ffaf469d40fc8596d3957ee94d21e9 Mon Sep 17 00:00:00 2001
From: AJ Moon <moonmeister@users.noreply.github.com>
Date: Mon, 31 Jul 2017 08:15:01 -0700
Subject: [GH-6366] Add functionality to disable Authentication when connecting
 to SMTP (#6639)

* Issue #6366: Add feature to disable auth for Encrypted connections to SMTP settings.

* Clean PLAIN AUTH Option

* Reorder SMTP server setup and change helptext

* remove unneeded setting and modify logic

* text description change
---
 .../connection_security_dropdown_setting.jsx       | 19 -----
 webapp/components/admin_console/email_settings.jsx | 81 ++++++++++++++--------
 2 files changed, 51 insertions(+), 49 deletions(-)

(limited to 'webapp/components')

diff --git a/webapp/components/admin_console/connection_security_dropdown_setting.jsx b/webapp/components/admin_console/connection_security_dropdown_setting.jsx
index 3a8e5f7fe..b7b283be1 100644
--- a/webapp/components/admin_console/connection_security_dropdown_setting.jsx
+++ b/webapp/components/admin_console/connection_security_dropdown_setting.jsx
@@ -26,23 +26,6 @@ const SECTION_NONE = (
     </tr>
 );
 
-const SECTION_PLAIN = (
-    <tr>
-        <td>
-            <FormattedMessage
-                id='admin.connectionSecurityPlain'
-                defaultMessage='PLAIN'
-            />
-        </td>
-        <td>
-            <FormattedMessage
-                id='admin.connectionSecurityPlainDescription'
-                defaultMessage='Mattermost will connect and authenticate over an insecure connection.'
-            />
-        </td>
-    </tr>
-);
-
 const SECTION_TLS = (
     <tr>
         <td>
@@ -84,7 +67,6 @@ const CONNECTION_SECURITY_HELP_TEXT_EMAIL = (
     >
         <tbody>
             {SECTION_NONE}
-            {SECTION_PLAIN}
             {SECTION_TLS}
             {SECTION_STARTTLS}
         </tbody>
@@ -122,7 +104,6 @@ export function ConnectionSecurityDropdownSettingEmail(props) {
             id='connectionSecurity'
             values={[
                 {value: '', text: Utils.localizeMessage('admin.connectionSecurityNone', 'None')},
-                {value: 'PLAIN', text: Utils.localizeMessage('admin.connectionSecurityPlain')},
                 {value: 'TLS', text: Utils.localizeMessage('admin.connectionSecurityTls', 'TLS (Recommended)')},
                 {value: 'STARTTLS', text: Utils.localizeMessage('admin.connectionSecurityStart')}
             ]}
diff --git a/webapp/components/admin_console/email_settings.jsx b/webapp/components/admin_console/email_settings.jsx
index ddfe3c38f..d7694ebb6 100644
--- a/webapp/components/admin_console/email_settings.jsx
+++ b/webapp/components/admin_console/email_settings.jsx
@@ -32,6 +32,7 @@ export default class EmailSettings extends AdminSettings {
         config.EmailSettings.FeedbackName = this.state.feedbackName;
         config.EmailSettings.FeedbackEmail = this.state.feedbackEmail;
         config.EmailSettings.FeedbackOrganization = this.state.feedbackOrganization;
+        config.EmailSettings.EnableSMTPAuth = this.state.enableSMTPAuth;
         config.EmailSettings.SMTPUsername = this.state.smtpUsername;
         config.EmailSettings.SMTPPassword = this.state.smtpPassword;
         config.EmailSettings.SMTPServer = this.state.smtpServer;
@@ -56,6 +57,7 @@ export default class EmailSettings extends AdminSettings {
             feedbackName: config.EmailSettings.FeedbackName,
             feedbackEmail: config.EmailSettings.FeedbackEmail,
             feedbackOrganization: config.EmailSettings.FeedbackOrganization,
+            enableSMTPAuth: config.EmailSettings.EnableSMTPAuth,
             smtpUsername: config.EmailSettings.SMTPUsername,
             smtpPassword: config.EmailSettings.SMTPPassword,
             smtpServer: config.EmailSettings.SMTPServer,
@@ -202,80 +204,99 @@ export default class EmailSettings extends AdminSettings {
                     disabled={!this.state.sendEmailNotifications}
                 />
                 <TextSetting
-                    id='smtpUsername'
+                    id='smtpServer'
                     label={
                         <FormattedMessage
-                            id='admin.email.smtpUsernameTitle'
-                            defaultMessage='SMTP Server Username:'
+                            id='admin.email.smtpServerTitle'
+                            defaultMessage='SMTP Server:'
                         />
                     }
-                    placeholder={Utils.localizeMessage('admin.email.smtpUsernameExample', 'Ex: "admin@yourcompany.com", "AKIADTOVBGERKLCBV"')}
+                    placeholder={Utils.localizeMessage('admin.email.smtpServerExample', 'Ex: "smtp.yourcompany.com", "email-smtp.us-east-1.amazonaws.com"')}
                     helpText={
                         <FormattedMessage
-                            id='admin.email.smtpUsernameDescription'
-                            defaultMessage=' Obtain this credential from administrator setting up your email server.'
+                            id='admin.email.smtpServerDescription'
+                            defaultMessage='Location of SMTP email server.'
                         />
                     }
-                    value={this.state.smtpUsername}
+                    value={this.state.smtpServer}
                     onChange={this.handleChange}
                     disabled={!this.state.sendEmailNotifications}
                 />
                 <TextSetting
-                    id='smtpPassword'
+                    id='smtpPort'
                     label={
                         <FormattedMessage
-                            id='admin.email.smtpPasswordTitle'
-                            defaultMessage='SMTP Server Password:'
+                            id='admin.email.smtpPortTitle'
+                            defaultMessage='SMTP Server Port:'
                         />
                     }
-                    placeholder={Utils.localizeMessage('admin.email.smtpPasswordExample', 'Ex: "yourpassword", "jcuS8PuvcpGhpgHhlcpT1Mx42pnqMxQY"')}
+                    placeholder={Utils.localizeMessage('admin.email.smtpPortExample', 'Ex: "25", "465", "587"')}
                     helpText={
                         <FormattedMessage
-                            id='admin.email.smtpPasswordDescription'
-                            defaultMessage=' Obtain this credential from administrator setting up your email server.'
+                            id='admin.email.smtpPortDescription'
+                            defaultMessage='Port of SMTP email server.'
                         />
                     }
-                    value={this.state.smtpPassword}
+                    value={this.state.smtpPort}
+                    onChange={this.handleChange}
+                    disabled={!this.state.sendEmailNotifications}
+                />
+                <BooleanSetting
+                    id='enableSMTPAuth'
+                    label={
+                        <FormattedMessage
+                            id='admin.email.enableSMTPAuthTitle'
+                            defaultMessage='Enable SMTP Authentication: '
+                        />
+                    }
+                    helpText={[
+                        <FormattedHTMLMessage
+                            key='admin.email.enableSMTPAuthDesc'
+                            id='admin.email.enableSMTPAuthDesc'
+                            defaultMessage='When true, SMTP Authentication is enabled.'
+                        />
+                    ]}
+                    value={this.state.enableSMTPAuth}
                     onChange={this.handleChange}
                     disabled={!this.state.sendEmailNotifications}
                 />
                 <TextSetting
-                    id='smtpServer'
+                    id='smtpUsername'
                     label={
                         <FormattedMessage
-                            id='admin.email.smtpServerTitle'
-                            defaultMessage='SMTP Server:'
+                            id='admin.email.smtpUsernameTitle'
+                            defaultMessage='SMTP Server Username:'
                         />
                     }
-                    placeholder={Utils.localizeMessage('admin.email.smtpServerExample', 'Ex: "smtp.yourcompany.com", "email-smtp.us-east-1.amazonaws.com"')}
+                    placeholder={Utils.localizeMessage('admin.email.smtpUsernameExample', 'Ex: "admin@yourcompany.com", "AKIADTOVBGERKLCBV"')}
                     helpText={
                         <FormattedMessage
-                            id='admin.email.smtpServerDescription'
-                            defaultMessage='Location of SMTP email server.'
+                            id='admin.email.smtpUsernameDescription'
+                            defaultMessage=' Obtain this credential from administrator setting up your email server.'
                         />
                     }
-                    value={this.state.smtpServer}
+                    value={this.state.smtpUsername}
                     onChange={this.handleChange}
-                    disabled={!this.state.sendEmailNotifications}
+                    disabled={!this.state.sendEmailNotifications || !this.state.enableSMTPAuth}
                 />
                 <TextSetting
-                    id='smtpPort'
+                    id='smtpPassword'
                     label={
                         <FormattedMessage
-                            id='admin.email.smtpPortTitle'
-                            defaultMessage='SMTP Server Port:'
+                            id='admin.email.smtpPasswordTitle'
+                            defaultMessage='SMTP Server Password:'
                         />
                     }
-                    placeholder={Utils.localizeMessage('admin.email.smtpPortExample', 'Ex: "25", "465", "587"')}
+                    placeholder={Utils.localizeMessage('admin.email.smtpPasswordExample', 'Ex: "yourpassword", "jcuS8PuvcpGhpgHhlcpT1Mx42pnqMxQY"')}
                     helpText={
                         <FormattedMessage
-                            id='admin.email.smtpPortDescription'
-                            defaultMessage='Port of SMTP email server.'
+                            id='admin.email.smtpPasswordDescription'
+                            defaultMessage=' Obtain this credential from administrator setting up your email server.'
                         />
                     }
-                    value={this.state.smtpPort}
+                    value={this.state.smtpPassword}
                     onChange={this.handleChange}
-                    disabled={!this.state.sendEmailNotifications}
+                    disabled={!this.state.sendEmailNotifications || !this.state.enableSMTPAuth}
                 />
                 <ConnectionSecurityDropdownSettingEmail
                     value={this.state.connectionSecurity}
-- 
cgit v1.2.3-1-g7c22