From 0afa28de0953ed528486a7d7ad6000f344624710 Mon Sep 17 00:00:00 2001 From: Harrison Healey Date: Tue, 9 Aug 2016 09:53:22 -0400 Subject: Changed autodetection of SiteURL (#3764) * Changed autoconfiguration of SiteURL to be done on every request * Added SiteURL to system console --- .../admin_console/configuration_settings.jsx | 20 ++++++++++++++++++++ .../components/create_team/components/team_url.jsx | 2 +- .../components/installed_incoming_webhook.jsx | 2 +- 3 files changed, 22 insertions(+), 2 deletions(-) (limited to 'webapp/components') diff --git a/webapp/components/admin_console/configuration_settings.jsx b/webapp/components/admin_console/configuration_settings.jsx index e34167a30..6a07e31cd 100644 --- a/webapp/components/admin_console/configuration_settings.jsx +++ b/webapp/components/admin_console/configuration_settings.jsx @@ -28,6 +28,7 @@ export default class ConfigurationSettings extends AdminSettings { } getConfigFromState(config) { + config.ServiceSettings.SiteURL = this.state.siteURL; config.ServiceSettings.ListenAddress = this.state.listenAddress; config.ServiceSettings.WebserverMode = this.state.webserverMode; @@ -36,6 +37,7 @@ export default class ConfigurationSettings extends AdminSettings { getStateFromConfig(config) { return { + siteURL: config.ServiceSettings.SiteURL, listenAddress: config.ServiceSettings.ListenAddress, webserverMode: config.ServiceSettings.WebserverMode }; @@ -55,6 +57,24 @@ export default class ConfigurationSettings extends AdminSettings { renderSettings() { return ( + + } + placeholder={Utils.localizeMessage('admin.service.siteURLExample', 'Ex "https://mattermost.example.com:1234"')} + helpText={ + + } + value={this.state.siteURL} + onChange={this.handleChange} + /> {title} ); diff --git a/webapp/components/integrations/components/installed_incoming_webhook.jsx b/webapp/components/integrations/components/installed_incoming_webhook.jsx index 008000012..965ed2bc9 100644 --- a/webapp/components/integrations/components/installed_incoming_webhook.jsx +++ b/webapp/components/integrations/components/installed_incoming_webhook.jsx @@ -97,7 +97,7 @@ export default class InstalledIncomingWebhook extends React.Component { id='installed_integrations.url' defaultMessage='URL: {url}' values={{ - url: window.mm_config.SiteURL + '/hooks/' + incomingWebhook.id + url: Utils.getSiteURL() + '/hooks/' + incomingWebhook.id }} /> -- cgit v1.2.3-1-g7c22 From aa9f71039b10d1008a4f731204522856d15de6f3 Mon Sep 17 00:00:00 2001 From: Joram Wilander Date: Tue, 9 Aug 2016 11:19:42 -0400 Subject: Remove legacy code adding useless team name to oauth URLs (#3766) --- webapp/components/signup_user_complete.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'webapp/components') diff --git a/webapp/components/signup_user_complete.jsx b/webapp/components/signup_user_complete.jsx index 23e115124..eec143996 100644 --- a/webapp/components/signup_user_complete.jsx +++ b/webapp/components/signup_user_complete.jsx @@ -591,7 +591,7 @@ export default class SignupUserComplete extends React.Component { @@ -609,7 +609,7 @@ export default class SignupUserComplete extends React.Component { -- cgit v1.2.3-1-g7c22 From e4b0680a795bfeda5575f2be3e4b6359dc01bd2d Mon Sep 17 00:00:00 2001 From: David Lu Date: Tue, 9 Aug 2016 17:00:51 -0400 Subject: Fixed reset password error (#3769) --- .../components/admin_console/reset_password_modal.jsx | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) (limited to 'webapp/components') diff --git a/webapp/components/admin_console/reset_password_modal.jsx b/webapp/components/admin_console/reset_password_modal.jsx index 6d5a03f2a..dee04b87c 100644 --- a/webapp/components/admin_console/reset_password_modal.jsx +++ b/webapp/components/admin_console/reset_password_modal.jsx @@ -3,17 +3,10 @@ import ReactDOM from 'react-dom'; import Client from 'client/web_client.jsx'; -import Constants from 'utils/constants.jsx'; +import * as Utils from 'utils/utils.jsx'; import {Modal} from 'react-bootstrap'; -import {injectIntl, intlShape, defineMessages, FormattedMessage} from 'react-intl'; - -var holders = defineMessages({ - submit: { - id: 'admin.reset_password.submit', - defaultMessage: 'Please enter at least {chars} characters.' - } -}); +import {injectIntl, intlShape, FormattedMessage} from 'react-intl'; import React from 'react'; @@ -31,13 +24,13 @@ class ResetPasswordModal extends React.Component { doSubmit(e) { e.preventDefault(); - var password = ReactDOM.findDOMNode(this.refs.password).value; + const password = this.refs.password.value; - if (!password || password.length < Constants.MIN_PASSWORD_LENGTH) { - this.setState({serverError: this.props.intl.formatMessage(holders.submit, {chars: Constants.MIN_PASSWORD_LENGTH})}); + const passwordErr = Utils.isValidPassword(password); + if (passwordErr) { + this.setState({serverError: passwordErr}); return; } - this.setState({serverError: null}); Client.adminResetPassword( -- cgit v1.2.3-1-g7c22