From 58242905d62418c5cc4749dcac957378459eeb24 Mon Sep 17 00:00:00 2001 From: Joram Wilander Date: Tue, 30 Aug 2016 18:55:29 -0400 Subject: Fix scrollHeight console error when logging out of iOS app (#3909) --- webapp/components/post_view/components/post_list.jsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'webapp') diff --git a/webapp/components/post_view/components/post_list.jsx b/webapp/components/post_view/components/post_list.jsx index f891afdb3..b008245f6 100644 --- a/webapp/components/post_view/components/post_list.jsx +++ b/webapp/components/post_view/components/post_list.jsx @@ -49,6 +49,7 @@ export default class PostList extends React.Component { this.jumpToPostNode = null; this.wasAtBottom = true; this.scrollHeight = 0; + this.animationFrameId = 0; this.scrollStopAction = new DelayedAction(this.handleScrollStop); @@ -431,7 +432,7 @@ export default class PostList extends React.Component { } scrollToBottom() { - window.requestAnimationFrame(() => { + this.animationFrameId = window.requestAnimationFrame(() => { this.refs.postlist.scrollTop = this.refs.postlist.scrollHeight; }); } @@ -464,13 +465,14 @@ export default class PostList extends React.Component { } componentWillUnmount() { + window.cancelAnimationFrame(this.animationFrameId); window.removeEventListener('resize', this.handleResize); window.removeEventListener('keydown', this.handleKeyDown); this.scrollStopAction.cancel(); } componentDidUpdate() { - if (this.props.postList != null) { + if (this.props.postList != null && this.refs.postlist) { this.updateScrolling(); } } -- cgit v1.2.3-1-g7c22