From 8a0e649f989a824bb3bbfd1900a5b8e5383b47e1 Mon Sep 17 00:00:00 2001 From: Harrison Healey Date: Fri, 30 Sep 2016 11:06:30 -0400 Subject: PLT-3105 Files table migration (#4068) * Implemented initial changes for files table * Removed *_benchmark_test.go files * Re-implemented GetPublicFile and added support for old path * Localization for files table * Moved file system code into utils package * Finished server-side changes and added initial upgrade script * Added getPostFiles api * Re-add Extension and HasPreviewImage fields to FileInfo * Removed unused translation * Fixed merge conflicts left over after permissions changes * Forced FileInfo.extension to be lower case * Changed FileUploadResponse to contain the FileInfos instead of FileIds * Fixed permissions on getFile* calls * Fixed notifications for file uploads * Added initial version of client code for files changes * Permanently added FileIds field to Post object and removed Post.HasFiles * Updated PostStore.Update to be usable in more circumstances * Re-added Filenames field and switched file migration to be entirely lazy-loaded * Increased max listener count for FileStore * Removed unused fileInfoCache * Moved file system code back into api * Removed duplicate test case * Fixed unit test running on ports other than 8065 * Renamed HasPermissionToPostContext to HasPermissionToChannelByPostContext * Refactored handleImages to make it more easily understandable * Renamed getPostFiles to getFileInfosForPost * Re-added pre-FileIds posts to analytics * Changed files to be saved as their ids as opposed to id/filename.ext * Renamed FileInfo.UserId to FileInfo.CreatorId * Fixed detection of language in CodePreview * Fixed switching between threads in the RHS not loading new files * Add serverside protection against a rare bug where the client sends the same file twice for a single post * Refactored the important parts of uploadFile api call into a function that can be called without a web context --- webapp/actions/global_actions.jsx | 5 +- webapp/client/client.jsx | 71 ++++-- webapp/components/audio_video_preview.jsx | 12 +- webapp/components/code_preview.jsx | 18 +- webapp/components/create_comment.jsx | 36 +-- webapp/components/create_post.jsx | 47 ++-- webapp/components/file_attachment.jsx | 251 +++++++-------------- webapp/components/file_attachment_list.jsx | 55 +++-- .../components/file_attachment_list_container.jsx | 90 ++++++++ webapp/components/file_info_preview.jsx | 88 ++++---- webapp/components/file_preview.jsx | 83 +++---- webapp/components/file_upload.jsx | 9 +- webapp/components/get_public_link_modal.jsx | 6 +- webapp/components/pdf_preview.jsx | 24 +- .../commented_on_files_message_container.jsx | 88 ++++++++ .../components/post_view/components/post_body.jsx | 31 ++- webapp/components/rhs_comment.jsx | 12 +- webapp/components/rhs_root_post.jsx | 12 +- webapp/components/view_image.jsx | 140 ++++-------- webapp/sass/components/_files.scss | 4 + webapp/stores/file_store.jsx | 43 ++-- webapp/stores/notification_store.jsx | 2 +- webapp/stores/post_store.jsx | 6 +- webapp/tests/client_file.test.jsx | 248 ++++++++++++++++++++ webapp/tests/client_general.test.jsx | 38 ---- webapp/tests/client_post.test.jsx | 2 + webapp/utils/async_client.jsx | 60 +++-- webapp/utils/constants.jsx | 2 +- webapp/utils/syntax_hightlighting.jsx | 9 +- webapp/utils/utils.jsx | 17 +- 30 files changed, 866 insertions(+), 643 deletions(-) create mode 100644 webapp/components/file_attachment_list_container.jsx create mode 100644 webapp/components/post_view/components/commented_on_files_message_container.jsx create mode 100644 webapp/tests/client_file.test.jsx (limited to 'webapp') diff --git a/webapp/actions/global_actions.jsx b/webapp/actions/global_actions.jsx index bc7562d44..81c06fe93 100644 --- a/webapp/actions/global_actions.jsx +++ b/webapp/actions/global_actions.jsx @@ -294,11 +294,11 @@ export function showGetPostLinkModal(post) { }); } -export function showGetPublicLinkModal(filename) { +export function showGetPublicLinkModal(fileId) { AppDispatcher.handleViewAction({ type: ActionTypes.TOGGLE_GET_PUBLIC_LINK_MODAL, value: true, - filename + fileId }); } @@ -388,7 +388,6 @@ export function sendEphemeralPost(message, channelId) { type: Constants.POST_TYPE_EPHEMERAL, create_at: timestamp, update_at: timestamp, - filenames: [], props: {} }; diff --git a/webapp/client/client.jsx b/webapp/client/client.jsx index 439d41f78..334f8374d 100644 --- a/webapp/client/client.jsx +++ b/webapp/client/client.jsx @@ -113,10 +113,14 @@ export default class Client { return `${this.url}${this.urlVersion}/users`; } - getFilesRoute() { + getTeamFilesRoute() { return `${this.url}${this.urlVersion}/teams/${this.getTeamId()}/files`; } + getFileRoute(fileId) { + return `${this.url}${this.urlVersion}/files/${fileId}`; + } + getOAuthRoute() { return `${this.url}${this.urlVersion}/oauth`; } @@ -1520,40 +1524,71 @@ export default class Client { end(this.handleResponse.bind(this, 'getFlaggedPosts', success, error)); } + getFileInfosForPost(channelId, postId, success, error) { + request. + get(`${this.getChannelNeededRoute(channelId)}/posts/${postId}/get_file_infos`). + set(this.defaultHeaders). + type('application/json'). + accept('application/json'). + end(this.handleResponse.bind(this, 'getFileInfosForPost', success, error)); + } + // Routes for Files - getFileInfo(filename, success, error) { + uploadFile(file, filename, channelId, clientId, success, error) { + return request. + post(`${this.getTeamFilesRoute()}/upload`). + set(this.defaultHeaders). + attach('files', file, filename). + field('channel_id', channelId). + field('client_ids', clientId). + accept('application/json'). + end(this.handleResponse.bind(this, 'uploadFile', success, error)); + } + + getFile(fileId, success, error) { request. - get(`${this.getFilesRoute()}/get_info${filename}`). + get(`${this.getFileRoute(fileId)}/get`). set(this.defaultHeaders). type('application/json'). accept('application/json'). - end(this.handleResponse.bind(this, 'getFileInfo', success, error)); + end(this.handleResponse.bind(this, 'getFile', success, error)); } - getPublicLink(filename, success, error) { - const data = { - filename - }; + getFileThumbnail(fileId, success, error) { + request. + get(`${this.getFileRoute(fileId)}/get_thumbnail`). + set(this.defaultHeaders). + type('application/json'). + accept('application/json'). + end(this.handleResponse.bind(this, 'getFileThumbnail', success, error)); + } + getFilePreview(fileId, success, error) { request. - post(`${this.getFilesRoute()}/get_public_link`). + get(`${this.getFileRoute(fileId)}/get`). set(this.defaultHeaders). type('application/json'). accept('application/json'). - send(data). - end(this.handleResponse.bind(this, 'getPublicLink', success, error)); + end(this.handleResponse.bind(this, 'getFilePreview', success, error)); } - uploadFile(file, filename, channelId, clientId, success, error) { - return request. - post(`${this.getFilesRoute()}/upload`). + getFileInfo(fileId, success, error) { + request. + get(`${this.getFileRoute(fileId)}/get_info`). set(this.defaultHeaders). - attach('files', file, filename). - field('channel_id', channelId). - field('client_ids', clientId). + type('application/json'). accept('application/json'). - end(this.handleResponse.bind(this, 'uploadFile', success, error)); + end(this.handleResponse.bind(this, 'getFileInfo', success, error)); + } + + getPublicLink(fileId, success, error) { + request. + get(`${this.getFileRoute(fileId)}/get_public_link`). + set(this.defaultHeaders). + type('application/json'). + accept('application/json'). + end(this.handleResponse.bind(this, 'getPublicLink', success, error)); } // Routes for OAuth diff --git a/webapp/components/audio_video_preview.jsx b/webapp/components/audio_video_preview.jsx index dd2e910b3..4956900a9 100644 --- a/webapp/components/audio_video_preview.jsx +++ b/webapp/components/audio_video_preview.jsx @@ -76,10 +76,8 @@ export default class AudioVideoPreview extends React.Component { if (!this.state.canPlay) { return ( ); } @@ -94,7 +92,7 @@ export default class AudioVideoPreview extends React.Component { // add a key to the video to prevent React from using an old video source while a new one is loading return (