From 8c18da21f3e51421a0dc6fbd4be1fa1e838dd482 Mon Sep 17 00:00:00 2001 From: Carlos Tadeu Panato Junior Date: Thu, 1 Dec 2016 15:04:33 +0100 Subject: Move instances of Client.updateChannel() in components to an action (#4643) * Move instances of Client.updateChannel() in components to an action * update per code review --- webapp/actions/channel_actions.jsx | 18 ++++++++++++++++++ webapp/components/rename_channel_modal.jsx | 7 ++----- 2 files changed, 20 insertions(+), 5 deletions(-) (limited to 'webapp') diff --git a/webapp/actions/channel_actions.jsx b/webapp/actions/channel_actions.jsx index ae32a481b..b108633d7 100644 --- a/webapp/actions/channel_actions.jsx +++ b/webapp/actions/channel_actions.jsx @@ -210,6 +210,24 @@ export function joinChannel(channel, success, error) { ); } +export function updateChannel(channel, success, error) { + Client.updateChannel( + channel, + () => { + AsyncClient.getChannel(channel.id); + + if (success) { + success(); + } + }, + (err) => { + if (error) { + error(err); + } + } + ); +} + export function searchMoreChannels(term, success, error) { Client.searchMoreChannels( term, diff --git a/webapp/components/rename_channel_modal.jsx b/webapp/components/rename_channel_modal.jsx index bb6d4f26d..3eaab834f 100644 --- a/webapp/components/rename_channel_modal.jsx +++ b/webapp/components/rename_channel_modal.jsx @@ -3,11 +3,10 @@ import ReactDOM from 'react-dom'; import * as Utils from 'utils/utils.jsx'; -import Client from 'client/web_client.jsx'; -import * as AsyncClient from 'utils/async_client.jsx'; import Constants from 'utils/constants.jsx'; import {intlShape, injectIntl, defineMessages, FormattedMessage} from 'react-intl'; +import {updateChannel} from 'actions/channel_actions.jsx'; import {Modal} from 'react-bootstrap'; @@ -161,10 +160,8 @@ export class RenameChannelModal extends React.Component { return; } - Client.updateChannel( - channel, + updateChannel(channel, () => { - AsyncClient.getChannel(channel.id); this.handleHide(); }, (err) => { -- cgit v1.2.3-1-g7c22