From 686c2fbab7607d42183ae685a27ea3d7dce8c3f6 Mon Sep 17 00:00:00 2001 From: Christopher Speller Date: Fri, 27 Apr 2018 12:49:45 -0700 Subject: Structured logging (#8673) * Implementing structured logging * Changes to en.json to allow refactor to run. * Fixing global logger * Structured logger initalization. * Add caller. * Do some log redirection. * Auto refactor * Cleaning up l4g reference and removing dependancy. * Removing junk. * Copyright headers. * Fixing tests * Revert "Changes to en.json to allow refactor to run." This reverts commit fd8249e99bcad0231e6ea65cd77c32aae9a54026. * Fixing some auto refactor strangeness and typo. * Making keys more human readable. --- wsapi/status.go | 5 ++--- wsapi/websocket_handler.go | 10 +++++----- 2 files changed, 7 insertions(+), 8 deletions(-) (limited to 'wsapi') diff --git a/wsapi/status.go b/wsapi/status.go index c3d323053..113bb7ed5 100644 --- a/wsapi/status.go +++ b/wsapi/status.go @@ -4,8 +4,7 @@ package wsapi import ( - l4g "github.com/alecthomas/log4go" - + "github.com/mattermost/mattermost-server/mlog" "github.com/mattermost/mattermost-server/model" ) @@ -22,7 +21,7 @@ func (api *API) getStatuses(req *model.WebSocketRequest) (map[string]interface{} func (api *API) getStatusesByIds(req *model.WebSocketRequest) (map[string]interface{}, *model.AppError) { var userIds []string if userIds = model.ArrayFromInterface(req.Data["user_ids"]); len(userIds) == 0 { - l4g.Error(model.StringInterfaceToJson(req.Data)) + mlog.Error(model.StringInterfaceToJson(req.Data)) return nil, NewInvalidWebSocketParamError(req.Action, "user_ids") } diff --git a/wsapi/websocket_handler.go b/wsapi/websocket_handler.go index 0208de140..dc6bd06d9 100644 --- a/wsapi/websocket_handler.go +++ b/wsapi/websocket_handler.go @@ -4,11 +4,11 @@ package wsapi import ( - l4g "github.com/alecthomas/log4go" - + "fmt" "net/http" "github.com/mattermost/mattermost-server/app" + "github.com/mattermost/mattermost-server/mlog" "github.com/mattermost/mattermost-server/model" "github.com/mattermost/mattermost-server/utils" ) @@ -23,11 +23,11 @@ type webSocketHandler struct { } func (wh webSocketHandler) ServeWebSocket(conn *app.WebConn, r *model.WebSocketRequest) { - l4g.Debug("websocket: %s", r.Action) + mlog.Debug(fmt.Sprintf("websocket: %s", r.Action)) session, sessionErr := wh.app.GetSession(conn.GetSessionToken()) if sessionErr != nil { - l4g.Error(utils.T("api.web_socket_handler.log.error"), "websocket", r.Action, r.Seq, conn.UserId, sessionErr.SystemMessage(utils.T), sessionErr.Error()) + mlog.Error(fmt.Sprintf("%v:%v seq=%v uid=%v %v [details: %v]", "websocket", r.Action, r.Seq, conn.UserId, sessionErr.SystemMessage(utils.T), sessionErr.Error())) sessionErr.DetailedError = "" errResp := model.NewWebSocketError(r.Seq, sessionErr) @@ -43,7 +43,7 @@ func (wh webSocketHandler) ServeWebSocket(conn *app.WebConn, r *model.WebSocketR var err *model.AppError if data, err = wh.handlerFunc(r); err != nil { - l4g.Error(utils.T("api.web_socket_handler.log.error"), "websocket", r.Action, r.Seq, r.Session.UserId, err.SystemMessage(utils.T), err.DetailedError) + mlog.Error(fmt.Sprintf("%v:%v seq=%v uid=%v %v [details: %v]", "websocket", r.Action, r.Seq, r.Session.UserId, err.SystemMessage(utils.T), err.DetailedError)) err.DetailedError = "" errResp := model.NewWebSocketError(r.Seq, err) -- cgit v1.2.3-1-g7c22