From 7b5d08afd143baa835ecc40eab115d353e5d87dd Mon Sep 17 00:00:00 2001 From: David Renshaw Date: Mon, 21 Nov 2016 22:49:53 -0500 Subject: fix bug where old users could see broken presence indicators on new users --- server/publications/boards.js | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/server/publications/boards.js b/server/publications/boards.js index cd3ef238..fd352552 100644 --- a/server/publications/boards.js +++ b/server/publications/boards.js @@ -99,20 +99,21 @@ Meteor.publishRelations('board', function(boardId) { this.cursor(Attachments.find({ cardId })); }); - // Board members. This publication also includes former board members that - // aren't members anymore but may have some activities attached to them in - // the history. - // - this.cursor(Users.find({ - _id: { $in: _.pluck(board.members, 'userId') }, - }, { fields: { - 'username': 1, - 'profile.fullname': 1, - 'profile.avatarUrl': 1, - }}), function(userId) { - // Presence indicators - this.cursor(presences.find({ userId })); - }); + if (board.members) { + // Board members. This publication also includes former board members that + // aren't members anymore but may have some activities attached to them in + // the history. + this.cursor(Users.find({ + _id: { $in: _.pluck(board.members, 'userId') }, + }, { fields: { + 'username': 1, + 'profile.fullname': 1, + 'profile.avatarUrl': 1, + }}), function(userId) { + // Presence indicators + this.cursor(presences.find({ userId })); + }); + } }); return this.ready(); -- cgit v1.2.3-1-g7c22