From be9adfaad4032ddb3d78a7ce4ede23d4a7053ab8 Mon Sep 17 00:00:00 2001 From: Joel Louzado Date: Wed, 15 Feb 2017 21:08:30 +0530 Subject: Added tooltip to `MenuBoard` button --- client/components/boards/boardHeader.jade | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/components/boards/boardHeader.jade b/client/components/boards/boardHeader.jade index 03768b36..033d240a 100644 --- a/client/components/boards/boardHeader.jade +++ b/client/components/boards/boardHeader.jade @@ -92,7 +92,7 @@ template(name="boardHeaderBar") i.fa.fa-times-thin .separator - a.board-header-btn.js-open-board-menu + a.board-header-btn.js-open-board-menu(title="{{_ 'boardMenuPopup-title'}}") i.board-header-btn-icon.fa.fa-navicon template(name="boardMenuPopup") -- cgit v1.2.3-1-g7c22 From 7393818fc0ec5e9d32815ada51bf434c2ba79dec Mon Sep 17 00:00:00 2001 From: Joel Louzado Date: Wed, 15 Feb 2017 21:30:03 +0530 Subject: Added dynamic tooltip for sidebar tongue --- client/components/sidebar/sidebar.jade | 2 +- client/components/sidebar/sidebar.js | 7 +++++++ i18n/en.i18n.json | 2 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/client/components/sidebar/sidebar.jade b/client/components/sidebar/sidebar.jade index cb0845af..572890b6 100644 --- a/client/components/sidebar/sidebar.jade +++ b/client/components/sidebar/sidebar.jade @@ -1,7 +1,7 @@ template(name="sidebar") .board-sidebar.sidebar(class="{{#if isOpen}}is-open{{/if}}") a.sidebar-tongue.js-toggle-sidebar( - class="{{#if isTongueHidden}}is-hidden{{/if}}") + class="{{#if isTongueHidden}}is-hidden{{/if}}")(title="{{showTongueTitle}}") i.fa.fa-angle-left .sidebar-shadow .sidebar-content.sidebar-shortcuts diff --git a/client/components/sidebar/sidebar.js b/client/components/sidebar/sidebar.js index 9eab1656..6e9a1be9 100644 --- a/client/components/sidebar/sidebar.js +++ b/client/components/sidebar/sidebar.js @@ -89,6 +89,13 @@ BlazeComponent.extendComponent({ return TAPi18n.__(viewTitles[this.getView()]); }, + showTongueTitle() { + if (this.isOpen()) + return `${TAPi18n.__('sidebar-close')}`; + else + return `${TAPi18n.__('sidebar-open')}`; + }, + events() { return [{ 'click .js-hide-sidebar': this.hide, diff --git a/i18n/en.i18n.json b/i18n/en.i18n.json index 5d52e390..b6c98152 100644 --- a/i18n/en.i18n.json +++ b/i18n/en.i18n.json @@ -293,6 +293,8 @@ "shortcut-toggle-filterbar": "Toggle Filter Sidebar", "shortcut-toggle-sidebar": "Toggle Board Sidebar", "show-cards-minimum-count": "Show cards count if list contains more than", + "sidebar-open": "Open Sidebar", + "sidebar-close": "Close Sidebar", "signupPopup-title": "Create an Account", "star-board-title": "Click to star this board. It will show up at top of your boards list.", "starred-boards": "Starred Boards", -- cgit v1.2.3-1-g7c22 From 46d19af6d9a1e0fe57079766695d90ee0b8bf627 Mon Sep 17 00:00:00 2001 From: Joel Louzado Date: Wed, 15 Feb 2017 21:34:52 +0530 Subject: removed trailing-whitespace --- client/components/sidebar/sidebar.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/components/sidebar/sidebar.js b/client/components/sidebar/sidebar.js index 6e9a1be9..f649b4ad 100644 --- a/client/components/sidebar/sidebar.js +++ b/client/components/sidebar/sidebar.js @@ -92,7 +92,7 @@ BlazeComponent.extendComponent({ showTongueTitle() { if (this.isOpen()) return `${TAPi18n.__('sidebar-close')}`; - else + else return `${TAPi18n.__('sidebar-open')}`; }, -- cgit v1.2.3-1-g7c22