From 7dae37eeac636b3928833bbac159c5e911de81be Mon Sep 17 00:00:00 2001 From: couscous3 <33840325+couscous3@users.noreply.github.com> Date: Mon, 20 Nov 2017 18:25:56 +0100 Subject: card detail: fix title editing with shift key in firefox there is no global `event` object, therefore we should use the `evt` argument from the event handler --- client/components/cards/cardDetails.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/components/cards/cardDetails.js b/client/components/cards/cardDetails.js index 3825bda8..ab062385 100644 --- a/client/components/cards/cardDetails.js +++ b/client/components/cards/cardDetails.js @@ -198,7 +198,7 @@ Template.editCardTitleForm.events({ 'keydown .js-edit-card-title' (evt) { // If enter key was pressed, submit the data // Unless the shift key is also being pressed - if (evt.keyCode === 13 && !event.shiftKey) { + if (evt.keyCode === 13 && !evt.shiftKey) { $('.js-submit-edit-card-title-form').click(); } }, -- cgit v1.2.3-1-g7c22 From 552fa32b87e0241e44fc2636f76b2fecfce89226 Mon Sep 17 00:00:00 2001 From: Lauri Ojansivu Date: Tue, 21 Nov 2017 09:30:31 +0200 Subject: Card details: fix title editing with shift key. Thanks to couscous3 ! --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1f269401..0593a080 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,8 @@ This release adds the following new features: and fixes the following bugs: * [Board list with long-description boards not visible](https://github.com/wekan/wekan/pull/1346); -* [Remove erroneous minicard title whitespace](https://github.com/wekan/wekan/pull/1347). +* [Remove erroneous minicard title whitespace](https://github.com/wekan/wekan/pull/1347); +* [Card details: fix title editing with shift key](https://github.com/wekan/wekan/pull/1348). Thanks to GitHub users couscous3, GhassenRjab and thuanpq for their contributions. -- cgit v1.2.3-1-g7c22