From 991e74bfc287d840951b7c707b7ff2a2f26e5001 Mon Sep 17 00:00:00 2001 From: IgnatzHome Date: Thu, 14 Jun 2018 19:38:57 +0200 Subject: testing mobile detail view fix. --- client/components/cards/cardDetails.js | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) (limited to 'client/components/cards') diff --git a/client/components/cards/cardDetails.js b/client/components/cards/cardDetails.js index 26549fda..a2bf2d02 100644 --- a/client/components/cards/cardDetails.js +++ b/client/components/cards/cardDetails.js @@ -21,8 +21,10 @@ BlazeComponent.extendComponent({ onCreated() { this.isLoaded = new ReactiveVar(false); - this.parentComponent().parentComponent().showOverlay.set(true); - this.parentComponent().parentComponent().mouseHasEnterCardDetails = false; + let parentComponent = this.parentComponent().parentComponent(); + if (parentComponent === null) parentComponent = this.parentComponent(); + parentComponent.showOverlay.set(true); + parentComponent.mouseHasEnterCardDetails = false; this.calculateNextPeak(); Meteor.subscribe('unsaved-edits'); @@ -43,8 +45,8 @@ BlazeComponent.extendComponent({ scrollParentContainer() { const cardPanelWidth = 510; - const bodyBoardComponent = this.parentComponent().parentComponent(); - + let bodyBoardComponent = this.parentComponent().parentComponent(); + if (bodyBoardComponent === null) bodyBoardComponent = this.parentComponent(); const $cardView = this.$(this.firstNode()); const $cardContainer = bodyBoardComponent.$('.js-swimlanes'); const cardContainerScroll = $cardContainer.scrollLeft(); @@ -115,7 +117,9 @@ BlazeComponent.extendComponent({ }, onDestroyed() { - this.parentComponent().parentComponent().showOverlay.set(false); + let parentComponent = this.parentComponent().parentComponent(); + if (parentComponent === null) parentComponent = this.parentComponent(); + parentComponent.showOverlay.set(false); }, events() { @@ -154,8 +158,10 @@ BlazeComponent.extendComponent({ 'click .js-due-date': Popup.open('editCardDueDate'), 'click .js-end-date': Popup.open('editCardEndDate'), 'mouseenter .js-card-details' () { - this.parentComponent().parentComponent().showOverlay.set(true); - this.parentComponent().parentComponent().mouseHasEnterCardDetails = true; + let parentComponent = this.parentComponent().parentComponent(); + if (parentComponent === null) parentComponent = this.parentComponent(); + parentComponent.showOverlay.set(true); + parentComponent.mouseHasEnterCardDetails = true; }, 'click #toggleButton'() { Meteor.call('toggleSystemMessages'); -- cgit v1.2.3-1-g7c22 From 04925f7347b7bb1f4384a96e1d56cd2cf3c351e9 Mon Sep 17 00:00:00 2001 From: IgnatzHome Date: Thu, 14 Jun 2018 20:11:29 +0200 Subject: trying to understand hirachy --- client/components/cards/cardDetails.js | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'client/components/cards') diff --git a/client/components/cards/cardDetails.js b/client/components/cards/cardDetails.js index 1a8a8bef..a7b18fc3 100644 --- a/client/components/cards/cardDetails.js +++ b/client/components/cards/cardDetails.js @@ -21,6 +21,10 @@ BlazeComponent.extendComponent({ onCreated() { this.isLoaded = new ReactiveVar(false); + console.log(this.parentComponent()); + console.log(this.parentComponent().parentComponent()); + console.log(JSON.stringify(this.parentComponent())); + console.log(JSON.stringify(this.parentComponent().parentComponent())); let parentComponent = this.parentComponent().parentComponent(); if (parentComponent === null) parentComponent = this.parentComponent(); parentComponent.showOverlay.set(true); -- cgit v1.2.3-1-g7c22 From 61ee6cf09fd4829136c598bcfce25b5e522d0097 Mon Sep 17 00:00:00 2001 From: IgnatzHome Date: Thu, 14 Jun 2018 20:26:44 +0200 Subject: This seems to make more sense. --- client/components/cards/cardDetails.js | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) (limited to 'client/components/cards') diff --git a/client/components/cards/cardDetails.js b/client/components/cards/cardDetails.js index a7b18fc3..72ed678b 100644 --- a/client/components/cards/cardDetails.js +++ b/client/components/cards/cardDetails.js @@ -21,14 +21,12 @@ BlazeComponent.extendComponent({ onCreated() { this.isLoaded = new ReactiveVar(false); - console.log(this.parentComponent()); - console.log(this.parentComponent().parentComponent()); - console.log(JSON.stringify(this.parentComponent())); - console.log(JSON.stringify(this.parentComponent().parentComponent())); - let parentComponent = this.parentComponent().parentComponent(); - if (parentComponent === null) parentComponent = this.parentComponent(); - parentComponent.showOverlay.set(true); - parentComponent.mouseHasEnterCardDetails = false; + const boardBody = this.parentComponent().parentComponent(); + //in Miniview parent is Board, not BoardBody. + if (boardBody !== null){ + boardBody.showOverlay.set(true); + boardBody.mouseHasEnterCardDetails = false; + } this.calculateNextPeak(); Meteor.subscribe('unsaved-edits'); @@ -49,8 +47,9 @@ BlazeComponent.extendComponent({ scrollParentContainer() { const cardPanelWidth = 510; - let bodyBoardComponent = this.parentComponent().parentComponent(); - if (bodyBoardComponent === null) bodyBoardComponent = this.parentComponent(); + const bodyBoardComponent = this.parentComponent().parentComponent(); + //On Mobile View Parent is Board, Not Board Body. I cant see how this funciton should work then. + if (bodyBoardComponent === null) return; const $cardView = this.$(this.firstNode()); const $cardContainer = bodyBoardComponent.$('.js-swimlanes'); const cardContainerScroll = $cardContainer.scrollLeft(); @@ -121,8 +120,9 @@ BlazeComponent.extendComponent({ }, onDestroyed() { - let parentComponent = this.parentComponent().parentComponent(); - if (parentComponent === null) parentComponent = this.parentComponent(); + const parentComponent = this.parentComponent().parentComponent(); + //on mobile view parent is Board, not board body. + if (parentComponent === null) return; parentComponent.showOverlay.set(false); }, @@ -176,8 +176,9 @@ BlazeComponent.extendComponent({ 'click .js-due-date': Popup.open('editCardDueDate'), 'click .js-end-date': Popup.open('editCardEndDate'), 'mouseenter .js-card-details' () { - let parentComponent = this.parentComponent().parentComponent(); - if (parentComponent === null) parentComponent = this.parentComponent(); + const parentComponent = this.parentComponent().parentComponent(); + //on mobile view parent is Board, not BoardBody. + if (parentComponent === null) return; parentComponent.showOverlay.set(true); parentComponent.mouseHasEnterCardDetails = true; }, -- cgit v1.2.3-1-g7c22