From 67454d0491ca17e61eb50034ecb5d03c85dd5abe Mon Sep 17 00:00:00 2001
From: RJevnikar <12701645+rjevnikar@users.noreply.github.com>
Date: Wed, 13 Jun 2018 22:18:00 +0000
Subject: Fix data colour changes on cards. Addressing both #1685 and #1693

---
 client/components/cards/cardDate.js | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

(limited to 'client/components/cards')

diff --git a/client/components/cards/cardDate.js b/client/components/cards/cardDate.js
index e95c3a23..83cc1424 100644
--- a/client/components/cards/cardDate.js
+++ b/client/components/cards/cardDate.js
@@ -279,14 +279,18 @@ class CardDueDate extends CardDate {
 
   classes() {
     let classes = 'due-date' + ' ';
-    if ((this.now.get().diff(this.date.get(), 'days') >= 2) &&
+    // if endAt exists & is < dueAt, dueAt doesn't need to be flagged 
+    if ((this.data().endAt != 0) &&
+       (this.data().endAt != null) &&
+       (this.data().endAt != '') &&
+       (this.data().endAt != undefined) &&
        (this.date.get().isBefore(this.data().endAt)))
+      classes += 'current';
+    else if (this.now.get().diff(this.date.get(), 'days') >= 2)
       classes += 'long-overdue';
-    else if ((this.now.get().diff(this.date.get(), 'minute') >= 0) &&
-       (this.date.get().isBefore(this.data().endAt)))
+    else if (this.now.get().diff(this.date.get(), 'minute') >= 0)
       classes += 'due';
-    else if ((this.now.get().diff(this.date.get(), 'days') >= -1) &&
-       (this.date.get().isBefore(this.data().endAt)))
+    else if (this.now.get().diff(this.date.get(), 'days') >= -1)
       classes += 'almost-due';
     return classes;
   }
@@ -316,10 +320,10 @@ class CardEndDate extends CardDate {
     let classes = 'end-date' + ' ';
     if (this.data.dueAt.diff(this.date.get(), 'days') >= 2)
       classes += 'long-overdue';
-    else if (this.data.dueAt.diff(this.date.get(), 'days') >= 0)
+    else if (this.data.dueAt.diff(this.date.get(), 'days') > 0)
       classes += 'due';
-    else if (this.data.dueAt.diff(this.date.get(), 'days') >= -2)
-      classes += 'almost-due';
+    else if (this.data.dueAt.diff(this.date.get(), 'days') <= 0)
+      classes += 'current';
     return classes;
   }
 
-- 
cgit v1.2.3-1-g7c22


From edd2e9db3ca070c87c47a14a3458184ceb5edb34 Mon Sep 17 00:00:00 2001
From: RJevnikar <12701645+rjevnikar@users.noreply.github.com>
Date: Wed, 13 Jun 2018 22:26:45 +0000
Subject: Fix lint errors

---
 client/components/cards/cardDate.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

(limited to 'client/components/cards')

diff --git a/client/components/cards/cardDate.js b/client/components/cards/cardDate.js
index 83cc1424..c3e0524d 100644
--- a/client/components/cards/cardDate.js
+++ b/client/components/cards/cardDate.js
@@ -279,11 +279,11 @@ class CardDueDate extends CardDate {
 
   classes() {
     let classes = 'due-date' + ' ';
-    // if endAt exists & is < dueAt, dueAt doesn't need to be flagged 
-    if ((this.data().endAt != 0) &&
-       (this.data().endAt != null) &&
-       (this.data().endAt != '') &&
-       (this.data().endAt != undefined) &&
+    // if endAt exists & is < dueAt, dueAt doesn't need to be flagged
+    if ((this.data().endAt !== 0) &&
+       (this.data().endAt !== null) &&
+       (this.data().endAt !== '') &&
+       (this.data().endAt !== undefined) &&
        (this.date.get().isBefore(this.data().endAt)))
       classes += 'current';
     else if (this.now.get().diff(this.date.get(), 'days') >= 2)
-- 
cgit v1.2.3-1-g7c22


From 718adc6c4727022063a7cf04386c641db0b6dc3f Mon Sep 17 00:00:00 2001
From: RJevnikar <12701645+rjevnikar@users.noreply.github.com>
Date: Thu, 14 Jun 2018 16:11:41 +0000
Subject: Fix minicardReceivedDate typo identified in #1694

---
 client/components/cards/minicard.jade | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'client/components/cards')

diff --git a/client/components/cards/minicard.jade b/client/components/cards/minicard.jade
index b44021a6..6dac4e12 100644
--- a/client/components/cards/minicard.jade
+++ b/client/components/cards/minicard.jade
@@ -15,7 +15,7 @@ template(name="minicard")
           unless dueAt
             unless endAt
               .date
-                +miniCardReceivedDate
+                +minicardReceivedDate
       if startAt
         .date
           +minicardStartDate
-- 
cgit v1.2.3-1-g7c22