From 6277bd2a90964a2ded6291153990bc0d26b56bae Mon Sep 17 00:00:00 2001 From: Alexander Sulfrian Date: Wed, 16 Sep 2015 04:30:02 +0200 Subject: Fix multiselect toggle logic If every element already has the label/member, we do not need to add it but it should be removed and if every element does not have the element, we should add it. --- client/components/sidebar/sidebarFilters.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'client/components/sidebar') diff --git a/client/components/sidebar/sidebarFilters.js b/client/components/sidebar/sidebarFilters.js index babd2f1e..bdecd63e 100644 --- a/client/components/sidebar/sidebarFilters.js +++ b/client/components/sidebar/sidebarFilters.js @@ -69,9 +69,9 @@ BlazeComponent.extendComponent({ const mappedSelection = this.mapSelection('label', labelId); if (_.every(mappedSelection)) { - mutateSelectedCards('addLabel', labelId); - } else if (_.every(mappedSelection, (bool) => !bool)) { mutateSelectedCards('removeLabel', labelId); + } else if (_.every(mappedSelection, (bool) => !bool)) { + mutateSelectedCards('addLabel', labelId); } else { const popup = Popup.open('disambiguateMultiLabel'); // XXX We need to have a better integration between the popup and the @@ -83,9 +83,9 @@ BlazeComponent.extendComponent({ const memberId = this.currentData()._id; const mappedSelection = this.mapSelection('member', memberId); if (_.every(mappedSelection)) { - mutateSelectedCards('assignMember', memberId); - } else if (_.every(mappedSelection, (bool) => !bool)) { mutateSelectedCards('unassignMember', memberId); + } else if (_.every(mappedSelection, (bool) => !bool)) { + mutateSelectedCards('assignMember', memberId); } else { const popup = Popup.open('disambiguateMultiMember'); // XXX We need to have a better integration between the popup and the -- cgit v1.2.3-1-g7c22