From ed8471be9b79243b016a275e5b11a6912717fbb9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20Manelli?= Date: Tue, 6 Mar 2018 21:17:20 -0300 Subject: Fix scroll when dragging elements. Remove scrollbars from swimlanes. --- client/components/lists/list.js | 3 +-- client/components/lists/list.styl | 1 + client/components/swimlanes/swimlanes.js | 2 +- client/components/swimlanes/swimlanes.styl | 7 ++----- 4 files changed, 5 insertions(+), 8 deletions(-) (limited to 'client/components') diff --git a/client/components/lists/list.js b/client/components/lists/list.js index d715c002..081b1e50 100644 --- a/client/components/lists/list.js +++ b/client/components/lists/list.js @@ -103,7 +103,7 @@ BlazeComponent.extendComponent({ $cards.sortable({ connectWith: '.js-minicards:not(.js-list-full)', tolerance: 'pointer', - appendTo: 'body', + appendTo: '.board-canvas', helper(evt, item) { const helper = item.clone(); if (MultiSelection.isActive()) { @@ -119,7 +119,6 @@ BlazeComponent.extendComponent({ }, distance: 7, items: itemsSelector, - scroll: false, placeholder: 'minicard-wrapper placeholder', start(evt, ui) { ui.placeholder.height(ui.helper.height()); diff --git a/client/components/lists/list.styl b/client/components/lists/list.styl index 839119ec..fa32ff6d 100644 --- a/client/components/lists/list.styl +++ b/client/components/lists/list.styl @@ -10,6 +10,7 @@ // transparent, because that won't work during a list drag. background: darken(white, 13%) border-left: 1px solid darken(white, 20%) + border-bottom: 1px solid #CCC padding: 0 float: left diff --git a/client/components/swimlanes/swimlanes.js b/client/components/swimlanes/swimlanes.js index bbfc9ca2..dacb487e 100644 --- a/client/components/swimlanes/swimlanes.js +++ b/client/components/swimlanes/swimlanes.js @@ -7,7 +7,7 @@ BlazeComponent.extendComponent({ $swimlanesDom.sortable({ tolerance: 'pointer', - appendTo: 'body', + appendTo: '.board-canvas', helper: 'clone', handle: '.js-swimlane-header', items: '.js-swimlane:not(.placeholder)', diff --git a/client/components/swimlanes/swimlanes.styl b/client/components/swimlanes/swimlanes.styl index 13257953..2e1d7e90 100644 --- a/client/components/swimlanes/swimlanes.styl +++ b/client/components/swimlanes/swimlanes.styl @@ -4,13 +4,9 @@ // Even if this background color is the same as the body we can't leave it // transparent, because that won't work during a swimlane drag. background: darken(white, 13%) - border-bottom: 1px solid #CCC display: flex flex-direction: row - margin: 0 0 10px - padding: 0 40px 5px 0 - overflow-x: auto - overflow-y: hidden + overflow: 0; &.placeholder background-color: rgba(0, 0, 0, .2) @@ -32,6 +28,7 @@ flex-direction: row; flex: 0 0 50px; padding-bottom: 30px; + border-bottom: 1px solid #CCC .swimlane-header writing-mode: sideways-lr; -- cgit v1.2.3-1-g7c22