From e2d0faa539e287247ccd1208fe74705169749210 Mon Sep 17 00:00:00 2001 From: Benjamin Tissoires Date: Tue, 26 Mar 2019 16:22:55 +0100 Subject: list: disconnect infinite-scroll observer to prevent memory leak --- client/components/lists/listBody.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'client') diff --git a/client/components/lists/listBody.js b/client/components/lists/listBody.js index 2e6591e2..112b6379 100644 --- a/client/components/lists/listBody.js +++ b/client/components/lists/listBody.js @@ -629,17 +629,21 @@ BlazeComponent.extendComponent({ threshold: 0.25, }; - const observer = new IntersectionObserver((entries) => { + this.observer = new IntersectionObserver((entries) => { entries.forEach((entry) => { this.spinnerShown = entry.isIntersecting; this.updateList(); }); }, options); - observer.observe(spinner); + this.observer.observe(spinner); } }, + onDestroyed() { + this.observer.disconnect(); + }, + updateList() { if (this.spinnerShown) { this.cardlimit.set(this.cardlimit.get() + InfiniteScrollIter); -- cgit v1.2.3-1-g7c22