From 19acd7861d1843460297f27e8da0c90dba6ebe54 Mon Sep 17 00:00:00 2001 From: Nico Date: Sun, 19 Jul 2020 19:57:23 +0200 Subject: Change slug on card rename --- models/boards.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'models') diff --git a/models/boards.js b/models/boards.js index f272e097..306bae13 100644 --- a/models/boards.js +++ b/models/boards.js @@ -18,18 +18,14 @@ Boards.attachSchema( type: String, // eslint-disable-next-line consistent-return autoValue() { - // XXX We need to improve slug management. Only the id should be necessary - // to identify a board in the code. - // XXX If the board title is updated, the slug should also be updated. // In some cases (Chinese and Japanese for instance) the `getSlug` function // return an empty string. This is causes bugs in our application so we set // a default slug in this case. - if (this.isInsert && !this.isSet) { + // Improvment would be to change client URL after slug is changed + const title = this.field('title'); + if (title.isSet && !this.isSet) { let slug = 'board'; - const title = this.field('title'); - if (title.isSet) { - slug = getSlug(title.value) || slug; - } + slug = getSlug(title.value) || slug; return slug; } }, -- cgit v1.2.3-1-g7c22