From afe00d02cddf016a3ccc1ed9a98a7f10d3339f26 Mon Sep 17 00:00:00 2001 From: Lauri Ojansivu Date: Thu, 18 Jun 2020 02:13:19 +0300 Subject: Add back checks about can user export CSV/TSV. Thanks to marc1006 and xet7 ! Related #3173 --- models/export.js | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) (limited to 'models') diff --git a/models/export.js b/models/export.js index 17b08dad..7a59fbec 100644 --- a/models/export.js +++ b/models/export.js @@ -80,19 +80,21 @@ if (Meteor.isServer) { }); } const exporter = new Exporter(boardId); - //if (exporter.canExport(user)) { - body = params.query.delimiter - ? exporter.buildCsv(params.query.delimiter) - : exporter.buildCsv(); - //'Content-Length': body.length, - res.writeHead(200, { - 'Content-Type': params.query.delimiter ? 'text/csv' : 'text/tsv', - }); - res.write(body); - res.end(); - //} else { - // res.writeHead(403); - // res.end('Permission Error'); - //} + if (exporter.canExport(user)) { + body = params.query.delimiter + ? exporter.buildCsv(params.query.delimiter) + : exporter.buildCsv(); + res.writeHead(200, { + // Checking length does not work https://github.com/wekan/wekan/issues/3173 + // so not using it here + //'Content-Length': body.length, + 'Content-Type': params.query.delimiter ? 'text/csv' : 'text/tsv', + }); + res.write(body); + res.end(); + } else { + res.writeHead(403); + res.end('Permission Error'); + } }); } -- cgit v1.2.3-1-g7c22