summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZac Medico <zmedico@gentoo.org>2008-12-20 20:24:18 +0000
committerZac Medico <zmedico@gentoo.org>2008-12-20 20:24:18 +0000
commit8c2d3450a6d0a14cd779057ce8e7b4e2003ca36b (patch)
tree7cd377a70a00d39c3e00a88effcf0086f3f398b1
parent724668cda60647914321a2d67c2c471802ba694d (diff)
downloadportage-8c2d3450a6d0a14cd779057ce8e7b4e2003ca36b.tar.gz
portage-8c2d3450a6d0a14cd779057ce8e7b4e2003ca36b.tar.bz2
portage-8c2d3450a6d0a14cd779057ce8e7b4e2003ca36b.zip
Adjust the EbuildNestedDie pattern so that it only matches when ( is surroundedv2.1.6.2
by whitespace. This filters out false positives triggered by sed expressions in net-analyzer/amap-5.2-r1 and media-libs/libsndfile-1.0.17-r1. Thanks to Diego Pettenò <flameeyes@g.o> for reporting. (trunk r12265) svn path=/main/branches/2.1.6/; revision=12267
-rw-r--r--pym/repoman/checks.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index 6f2c076c3..7565039f2 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -177,7 +177,7 @@ class EbuildNestedDie(LineCheck):
"""Check ebuild for nested die statements (die statements in subshells"""
repoman_check_name = 'ebuild.nesteddie'
- nesteddie_re = re.compile(r'^[^#]*\([^)]*\bdie\b')
+ nesteddie_re = re.compile(r'^[^#]*\s\(\s[^)]*\bdie\b')
def check(self, num, line):
if self.nesteddie_re.match(line):