diff options
| author | Zac Medico <zmedico@gentoo.org> | 2010-01-07 20:19:54 +0000 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2010-01-07 20:19:54 +0000 |
| commit | fcacb7a8d0cf8e39497922de3aeebf7ab3088e22 (patch) | |
| tree | 56b438b74bc81c7b6b24f1fa17dd916e78e25f60 | |
| parent | e3320a3ac33b806b66dede3255af1d3ec32f6897 (diff) | |
| download | portage-fcacb7a8d0cf8e39497922de3aeebf7ab3088e22.tar.gz portage-fcacb7a8d0cf8e39497922de3aeebf7ab3088e22.tar.bz2 portage-fcacb7a8d0cf8e39497922de3aeebf7ab3088e22.zip | |
Bug #269225 - Warn about virtuals with non-empty HOMEPAGE or LICENSE. Thanks
to Ulrich Müller <ulm@g.o> for this patch.
svn path=/main/trunk/; revision=15174
| -rwxr-xr-x | bin/repoman | 11 | ||||
| -rw-r--r-- | man/repoman.1 | 6 |
2 files changed, 17 insertions, 0 deletions
diff --git a/bin/repoman b/bin/repoman index 592e27372..f15a6e9ac 100755 --- a/bin/repoman +++ b/bin/repoman @@ -278,6 +278,7 @@ qahelp={ "KEYWORDS.stable":"Ebuilds that have been added directly with stable KEYWORDS", "KEYWORDS.stupid":"Ebuilds that use KEYWORDS=-* instead of package.mask", "LICENSE.missing":"Ebuilds that have a missing or empty LICENSE variable", + "LICENSE.virtual":"Virtuals that have a non-empty LICENSE variable", "DESCRIPTION.missing":"Ebuilds that have a missing or empty DESCRIPTION variable", "DESCRIPTION.toolong":"DESCRIPTION is over %d characters" % max_desc_len, "EAPI.definition":"EAPI is defined after an inherit call (must be defined before)", @@ -285,6 +286,7 @@ qahelp={ "EAPI.unsupported":"Ebuilds that have an unsupported EAPI version (you must upgrade portage)", "SLOT.invalid":"Ebuilds that have a missing or invalid SLOT variable value", "HOMEPAGE.missing":"Ebuilds that have a missing or empty HOMEPAGE variable", + "HOMEPAGE.virtual":"Virtuals that have a non-empty HOMEPAGE variable", "DEPEND.bad":"User-visible ebuilds with bad DEPEND settings (matched against *visible* ebuilds)", "RDEPEND.bad":"User-visible ebuilds with bad RDEPEND settings (matched against *visible* ebuilds)", "PDEPEND.bad":"User-visible ebuilds with bad PDEPEND settings (matched against *visible* ebuilds)", @@ -360,6 +362,8 @@ qawarnings = set(( "DEPEND.badmaskedindev","RDEPEND.badmaskedindev","PDEPEND.badmaskedindev", "DEPEND.badtilde", "RDEPEND.badtilde", "PDEPEND.badtilde", "DESCRIPTION.toolong", +"HOMEPAGE.virtual", +"LICENSE.virtual", "KEYWORDS.dropped", "KEYWORDS.stupid", "KEYWORDS.missing", @@ -1381,6 +1385,13 @@ for x in scanlist: stats[myqakey]=stats[myqakey]+1 fails[myqakey].append(x+"/"+y+".ebuild") + if catdir == "virtual": + for var in ("HOMEPAGE", "LICENSE"): + if myaux.get(var): + myqakey = var + ".virtual" + stats[myqakey] = stats[myqakey] + 1 + fails[myqakey].append(relative_path) + # 14 is the length of DESCRIPTION="" if len(myaux['DESCRIPTION']) > max_desc_len: stats['DESCRIPTION.toolong'] += 1 diff --git a/man/repoman.1 b/man/repoman.1 index dd318a3f9..129ffd00b 100644 --- a/man/repoman.1 +++ b/man/repoman.1 @@ -119,6 +119,9 @@ Ebuilds that have an unsupported EAPI version (you must upgrade portage) .B HOMEPAGE.missing Ebuilds that have a missing or empty HOMEPAGE variable .TP +.B HOMEPAGE.virtual +Virtuals that have a non-empty HOMEPAGE variable +.TP .B IUSE.invalid This ebuild has a variable in IUSE that is not in the use.desc or its metadata.xml file .TP @@ -149,6 +152,9 @@ Ebuilds that have a missing or empty LICENSE variable .B LICENSE.syntax Syntax error in LICENSE (usually an extra/missing space/parenthesis) .TP +.B LICENSE.virtual +Virtuals that have a non-empty LICENSE variable +.TP .B LIVEVCS.stable Ebuild is a live ebuild (cvs, git, darcs, svn, etc) checkout with stable keywords. .TP |