diff options
author | Zac Medico <zmedico@gentoo.org> | 2008-01-31 06:18:40 +0000 |
---|---|---|
committer | Zac Medico <zmedico@gentoo.org> | 2008-01-31 06:18:40 +0000 |
commit | 70e65f34ca274abb8a81005dc9674e3c9fac9037 (patch) | |
tree | 14898dc1a026f8232b06d0523a40885d0a281112 /bin/repoman | |
parent | a1c8df96f9ff6220700ce1cf3989bd6e12400ccb (diff) | |
download | portage-70e65f34ca274abb8a81005dc9674e3c9fac9037.tar.gz portage-70e65f34ca274abb8a81005dc9674e3c9fac9037.tar.bz2 portage-70e65f34ca274abb8a81005dc9674e3c9fac9037.zip |
Check for quoted ${A}. Thanks to maekke for this patch. (trunk r9206)
svn path=/main/branches/2.1.2/; revision=9240
Diffstat (limited to 'bin/repoman')
-rwxr-xr-x | bin/repoman | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/bin/repoman b/bin/repoman index fdd57f32c..674aa61fd 100755 --- a/bin/repoman +++ b/bin/repoman @@ -1029,9 +1029,20 @@ class Autotools(LineCheck): return ("Direct calls to '%s'" % m.group(2)) + \ " instead of using autotools.eclass on line: %d" +class EbuildQuotedA(LineCheck): + """Ensure ebuilds have no quoting around ${A}""" + + repoman_check_name = 'ebuild.minorsyn' + a_quoted = re.compile(r'.*\"\$(\{A\}|A)\"') + + def check(self, num, line): + match = self.a_quoted.match(line) + if match: + return "Quoted \"${A}\" on line: %d" + _constant_checks = tuple((c() for c in (Autotools, EbuildQuote, EbuildUselessDodoc, EbuildUselessCdS, - EbuildNestedDie))) + EbuildNestedDie, EbuildQuotedA))) def run_checks(contents): for num, line in enumerate(contents): |