summaryrefslogtreecommitdiffstats
path: root/pym/_emerge/depgraph.py
diff options
context:
space:
mode:
authorZac Medico <zmedico@gentoo.org>2012-06-19 14:27:11 -0700
committerZac Medico <zmedico@gentoo.org>2012-06-19 14:27:11 -0700
commit7fdb5d855e9bd97825c1886e9788ecb1539e7759 (patch)
tree175e0da77e8841103ae6e3bdca184ab72ca9dfb5 /pym/_emerge/depgraph.py
parent40a8c90fb0d7ba1b057858bf06928f6b19ab1f7f (diff)
downloadportage-7fdb5d855e9bd97825c1886e9788ecb1539e7759.tar.gz
portage-7fdb5d855e9bd97825c1886e9788ecb1539e7759.tar.bz2
portage-7fdb5d855e9bd97825c1886e9788ecb1539e7759.zip
depgraph: optimize slot conflict backtrack order
Diffstat (limited to 'pym/_emerge/depgraph.py')
-rw-r--r--pym/_emerge/depgraph.py8
1 files changed, 6 insertions, 2 deletions
diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
index 071d05863..291080ac7 100644
--- a/pym/_emerge/depgraph.py
+++ b/pym/_emerge/depgraph.py
@@ -366,7 +366,11 @@ class _dynamic_depgraph_config(object):
# This use used to check if we have accounted for blockers
# relevant to a package.
self._traversed_pkg_deps = set()
- self._slot_collision_info = {}
+ # This should be ordered such that the backtracker will
+ # attempt to solve conflicts which occurred earlier first,
+ # since an earlier conflict can be the cause of a conflict
+ # which occurs later.
+ self._slot_collision_info = OrderedDict()
# Slot collision nodes are not allowed to block other packages since
# blocker validation is only able to account for one package per slot.
self._slot_collision_nodes = set()
@@ -911,7 +915,7 @@ class depgraph(object):
to_be_masked = backtrack_data[-1][0]
self._dynamic_config._backtrack_infos.setdefault(
- "slot conflict", []).extend(backtrack_data)
+ "slot conflict", []).append(backtrack_data)
self._dynamic_config._need_restart = True
if debug:
msg = []