diff options
| author | Zac Medico <zmedico@gentoo.org> | 2012-12-28 22:30:09 -0800 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2012-12-28 22:30:09 -0800 |
| commit | 5e5a5cddfdeb3aa05932114fc1dce65b5be11ae9 (patch) | |
| tree | 3000e19e6917b7d1642d7c878972d5ec165e8878 /pym/portage/checksum.py | |
| parent | e94233871e20fd3852e511ed1bd91c2826870f50 (diff) | |
| download | portage-5e5a5cddfdeb3aa05932114fc1dce65b5be11ae9.tar.gz portage-5e5a5cddfdeb3aa05932114fc1dce65b5be11ae9.tar.bz2 portage-5e5a5cddfdeb3aa05932114fc1dce65b5be11ae9.zip | |
Use 'with file' more.
This helps to minimize ResourceWarning triggered by ^C with python3.
Diffstat (limited to 'pym/portage/checksum.py')
| -rw-r--r-- | pym/portage/checksum.py | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/pym/portage/checksum.py b/pym/portage/checksum.py index 30a9234e1..cd663e767 100644 --- a/pym/portage/checksum.py +++ b/pym/portage/checksum.py @@ -50,16 +50,15 @@ class _generate_hash_function(object): @type filename: String @return: The hash and size of the data """ - f = _open_file(filename) - blocksize = HASHING_BLOCKSIZE - data = f.read(blocksize) - size = 0 - checksum = self._hashobject() - while data: - checksum.update(data) - size = size + len(data) + with _open_file(filename) as f: + blocksize = HASHING_BLOCKSIZE + size = 0 + checksum = self._hashobject() data = f.read(blocksize) - f.close() + while data: + checksum.update(data) + size = size + len(data) + data = f.read(blocksize) return (checksum.hexdigest(), size) |