diff options
| author | Zac Medico <zmedico@gentoo.org> | 2008-03-25 04:04:44 +0000 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2008-03-25 04:04:44 +0000 |
| commit | da34bceea64b7bb19a6c2a831d6c593f0cbe3290 (patch) | |
| tree | 357a8ec46d735a5a7122d7433f18ab37de6a180c /pym/repoman | |
| parent | 133450d9cbf542d3313d403a4cd0add2f224be40 (diff) | |
| download | portage-da34bceea64b7bb19a6c2a831d6c593f0cbe3290.tar.gz portage-da34bceea64b7bb19a6c2a831d6c593f0cbe3290.tar.bz2 portage-da34bceea64b7bb19a6c2a831d6c593f0cbe3290.zip | |
Bug #212621 - Make the EbuildQuote check do quoting validation for misc
variables from games.eclass.
svn path=/main/trunk/; revision=9507
Diffstat (limited to 'pym/repoman')
| -rw-r--r-- | pym/repoman/checks.py | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index ea76f6a01..aa5bf1845 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -77,7 +77,14 @@ class EbuildQuote(LineCheck): repoman_check_name = 'ebuild.minorsyn' ignore_line = re.compile(r'(^$)|(^\s*#.*)|(^\s*\w+=.*)|(^\s*(local|export)\s+)') - var_names = r'(D|DISTDIR|FILESDIR|S|T|ROOT|WORKDIR)' + var_names = ["D", "DISTDIR", "FILESDIR", "S", "T", "ROOT", "WORKDIR"] + + # variables for games.eclass + var_names += ["Ddir", "dir", "GAMES_PREFIX_OPT", "GAMES_DATADIR", + "GAMES_DATADIR_BASE", "GAMES_SYSCONFDIR", "GAMES_STATEDIR", + "GAMES_LOGDIR", "GAMES_BINDIR"] + + var_names = "(%s)" % "|".join(var_names) var_reference = re.compile(r'\$(\{'+var_names+'\}|' + \ var_names + '\W)') missing_quotes = re.compile(r'(\s|^)[^"\'\s]*\$\{?' + var_names + \ |