diff options
Diffstat (limited to 'net_if')
-rwxr-xr-x | net_if | 17 |
1 files changed, 8 insertions, 9 deletions
@@ -61,7 +61,7 @@ sub get_if_status (@) { } sub get_if_stats ($) { - my $if = shift @_; + my $if = shift; my $stats = {}; open(PFCTL, "-|", "pfctl", "-vvsI", "-i", $if); @@ -85,14 +85,13 @@ sub get_if_stats ($) { } sub print_stats ($) { - my ($stats, $count, $perfdata, $if); - $stats = shift @_; + my $stats = shift; + my ($count, $perfdata); $count = keys %$stats; $perfdata = ""; - for (keys %$stats) { - $if = $_; - for (qw( in4 out4 in6 out6 )) { + for my $if (keys %$stats) { + for (qw( in4 out4 in6 out6 )) { $perfdata = "$perfdata $if-$_=$stats->{$if}->{$_};"; } } @@ -100,6 +99,7 @@ sub print_stats ($) { msg('ok', "$count interfaces |$perfdata"); } + my ($up, $down, $error) = get_if_status(@ARGV); if (@$error) { @@ -113,9 +113,8 @@ if (@$down) { } my $stats = {}; -while (@$up) { - my $if = shift @$up; +for my $if (@$up) { $stats->{$if} = get_if_stats($if); } -print_stats($stats) +print_stats($stats); |