summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobert Martin <rdm@google.com>2013-05-24 17:08:22 -0400
committerRobert Martin <rdm@google.com>2013-05-24 17:08:22 -0400
commit191d4c07ef8e678903e1111b7b8bd5573e05a3ec (patch)
tree489d9019f4f1b084e26f1c1aa5aba89f1a3ba5c4
parent563cd1d3f5022fefa74b5cb0339f2c98ba0f7645 (diff)
downloadaskbot-191d4c07ef8e678903e1111b7b8bd5573e05a3ec.tar.gz
askbot-191d4c07ef8e678903e1111b7b8bd5573e05a3ec.tar.bz2
askbot-191d4c07ef8e678903e1111b7b8bd5573e05a3ec.zip
prevent db_api test from clobbering global name
One of the tests checks that we can rename the GLOBAL_GROUP_NAME, but never reverts it to its original value. This causes future tests to fail even though they shouldn't. This fix reverts GLOBAL_GROUP_NAME after testing it can be changed.
-rw-r--r--askbot/tests/db_api_tests.py7
1 files changed, 5 insertions, 2 deletions
diff --git a/askbot/tests/db_api_tests.py b/askbot/tests/db_api_tests.py
index 8d775fd0..1a7ad9e4 100644
--- a/askbot/tests/db_api_tests.py
+++ b/askbot/tests/db_api_tests.py
@@ -514,9 +514,14 @@ class GroupTests(AskbotTestCase):
self.assertEqual(qa.groups.filter(name='private').exists(), True)
def test_global_group_name_setting_changes_group_name(self):
+ orig_group_name = askbot_settings.GLOBAL_GROUP_NAME;
askbot_settings.update('GLOBAL_GROUP_NAME', 'all-people')
group = models.Group.objects.get_global_group()
self.assertEqual(group.name, 'all-people')
+ # Revert the global group name, so we don't mess up other tests!
+ askbot_settings.update('GLOBAL_GROUP_NAME', orig_group_name);
+ group = models.Group.objects.get_global_group()
+ self.assertEqual(group.name, orig_group_name)
def test_ask_global_group_by_id_works(self):
group = models.Group.objects.get_global_group()
@@ -698,5 +703,3 @@ class LinkPostingTests(AskbotTestCase):
self.assert_no_link(question.html)
self.edit_question(user=admin, question=question, body_text=text + ' ok')
self.assert_has_link(question.html, 'http://wikipedia.org')
-
-