Merge remote branch 'github/python-pre27-compat' into splinev1.3.1-spline1

* github/python-pre27-compat:
  Client/Frame: avoid use of lxml-only getparent()
  Revert "Avoid use of lxml-only getparent()"

1 files changed, 12 insertions, 10 deletions

diff --git a/src/lib/Bcfg2/Client/Frame.py b/src/lib/Bcfg2/Client/Frame.py
index bf0b20f87..24b4f409c 100644
--- a/src/lib/Bcfg2/Client/Frame.py
+++ b/src/lib/Bcfg2/Client/Frame.py
@@ -211,7 +211,15 @@ class Frame(object):
 
         # take care of important entries first
         if not self.dryrun:
-            for parent in self.config.findall(".//Path/.."):
+            parent_map = dict((c, p)
+                              for p in self.config.getiterator()
+                              for c in p)
+            for cfile in self.config.findall(".//Path"):
+                if (cfile.get('name') not in self.__important__ or
+                    cfile.get('type') != 'file' or
+                    cfile not in self.whitelist):
+                    continue
+                parent = parent_map[cfile]
                 if ((parent.tag == "Bundle" and
                      ((self.setup['bundle'] and
                        parent.get("name") not in self.setup['bundle']) or
@@ -220,15 +228,9 @@ class Frame(object):
                     (parent.tag == "Independent" and
                      (self.setup['bundle'] or self.setup['skipindep']))):
                     continue
-                for cfile in parent.findall("./Path"):
-                    if (cfile.get('name') not in self.__important__ or
-                        cfile.get('type') != 'file' or
-                        cfile not in self.whitelist):
-                        continue
-                    tools = [t for t in self.tools
-                             if t.handlesEntry(cfile) and t.canVerify(cfile)]
-                    if not tools:
-                        continue
+                tools = [t for t in self.tools
+                         if t.handlesEntry(cfile) and t.canVerify(cfile)]
+                if tools:
                     if (self.setup['interactive'] and not
                         self.promptFilter("Install %s: %s? (y/N):", [cfile])):
                         self.whitelist.remove(cfile)