diff options
| author | John Morris <john@zultron.com> | 2012-09-11 09:16:50 -0500 |
|---|---|---|
| committer | John Morris <john@zultron.com> | 2012-09-11 16:11:48 -0500 |
| commit | e20b039306c0bac3286ab76a267593d57a1b1e3f (patch) | |
| tree | 7dfab4a0a8688b2e5e8b8af315fc23e12aedc309 | |
| parent | 9f177baaff0d5ea21a8655847ebd35bdd5a7db96 (diff) | |
| download | bcfg2-e20b039306c0bac3286ab76a267593d57a1b1e3f.tar.gz bcfg2-e20b039306c0bac3286ab76a267593d57a1b1e3f.tar.bz2 bcfg2-e20b039306c0bac3286ab76a267593d57a1b1e3f.zip | |
Chkconfig client tool: fix service start result logic
When the bcfg2 client installs a service turning it 'on' with
chkconfig, it then starts the service with 'service foo start'. If
all these succeed, it should return a True success value.
This fixes a bug where starting the service succeeds, but is
interpreted as failure, ultimately causing the host to be reported as
dirty.
| -rw-r--r-- | src/lib/Bcfg2/Client/Tools/Chkconfig.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/Bcfg2/Client/Tools/Chkconfig.py b/src/lib/Bcfg2/Client/Tools/Chkconfig.py index 29ec5dec9..b62fb9ef8 100644 --- a/src/lib/Bcfg2/Client/Tools/Chkconfig.py +++ b/src/lib/Bcfg2/Client/Tools/Chkconfig.py @@ -79,7 +79,7 @@ class Chkconfig(Bcfg2.Client.Tools.SvcTool): rv &= self.cmd.run(rcmd % (entry.get('name'), entry.get('status')))[0] == 0 if entry.get("current_status") == "off": - rv &= self.start_service(entry) + rv &= (self.start_service(entry) == 0) return rv def FindExtra(self): |