summaryrefslogtreecommitdiffstats
path: root/src/lib/Bcfg2/Server/Plugins/Cfg
diff options
context:
space:
mode:
authorTim Laszlo <tim.laszlo@gmail.com>2012-10-17 15:43:09 -0500
committerTim Laszlo <tim.laszlo@gmail.com>2012-10-17 15:43:09 -0500
commitf35a435e51cd814f6985b48fab4bfb7ca043f5f9 (patch)
tree3589085e9260d74f04ce588739f7c08bf535f2e6 /src/lib/Bcfg2/Server/Plugins/Cfg
parent7e4ee01d99e1ae775513f6f26767b457bf7656da (diff)
downloadbcfg2-f35a435e51cd814f6985b48fab4bfb7ca043f5f9.tar.gz
bcfg2-f35a435e51cd814f6985b48fab4bfb7ca043f5f9.tar.bz2
bcfg2-f35a435e51cd814f6985b48fab4bfb7ca043f5f9.zip
CfgLegacyInfo: Move the dict outside of the for loop
Diffstat (limited to 'src/lib/Bcfg2/Server/Plugins/Cfg')
-rw-r--r--src/lib/Bcfg2/Server/Plugins/Cfg/CfgLegacyInfo.py13
1 files changed, 6 insertions, 7 deletions
diff --git a/src/lib/Bcfg2/Server/Plugins/Cfg/CfgLegacyInfo.py b/src/lib/Bcfg2/Server/Plugins/Cfg/CfgLegacyInfo.py
index aedf579fc..7277d5d08 100644
--- a/src/lib/Bcfg2/Server/Plugins/Cfg/CfgLegacyInfo.py
+++ b/src/lib/Bcfg2/Server/Plugins/Cfg/CfgLegacyInfo.py
@@ -33,6 +33,7 @@ class CfgLegacyInfo(CfgInfo):
def handle_event(self, event):
if event.code2str() == 'deleted':
return
+ self.metadata = dict()
for line in open(self.path).readlines():
match = Bcfg2.Server.Plugin.INFO_REGEX.match(line)
if not match:
@@ -40,11 +41,9 @@ class CfgLegacyInfo(CfgInfo):
(event.filename, line))
continue
else:
- self.metadata = \
- dict([(key, value)
- for key, value in list(match.groupdict().items())
- if value])
- if ('mode' in self.metadata and
- len(self.metadata['mode']) == 3):
- self.metadata['mode'] = "0%s" % self.metadata['mode']
+ for key, value in list(match.groupdict().items()):
+ if value:
+ self.metadata[key] = value
+ if ('mode' in self.metadata and len(self.metadata['mode']) == 3):
+ self.metadata['mode'] = "0%s" % self.metadata['mode']
handle_event.__doc__ = CfgInfo.handle_event.__doc__