PLT-3105 Files table migration (#4068)

* Implemented initial changes for files table

* Removed *_benchmark_test.go files

* Re-implemented GetPublicFile and added support for old path

* Localization for files table

* Moved file system code into utils package

* Finished server-side changes and added initial upgrade script

* Added getPostFiles api

* Re-add Extension and HasPreviewImage fields to FileInfo

* Removed unused translation

* Fixed merge conflicts left over after permissions changes

* Forced FileInfo.extension to be lower case

* Changed FileUploadResponse to contain the FileInfos instead of FileIds

* Fixed permissions on getFile* calls

* Fixed notifications for file uploads

* Added initial version of client code for files changes

* Permanently added FileIds field to Post object and removed Post.HasFiles

* Updated PostStore.Update to be usable in more circumstances

* Re-added Filenames field and switched file migration to be entirely lazy-loaded

* Increased max listener count for FileStore

* Removed unused fileInfoCache

* Moved file system code back into api

* Removed duplicate test case

* Fixed unit test running on ports other than 8065

* Renamed HasPermissionToPostContext to HasPermissionToChannelByPostContext

* Refactored handleImages to make it more easily understandable

* Renamed getPostFiles to getFileInfosForPost

* Re-added pre-FileIds posts to analytics

* Changed files to be saved as their ids as opposed to id/filename.ext

* Renamed FileInfo.UserId to FileInfo.CreatorId

* Fixed detection of language in CodePreview

* Fixed switching between threads in the RHS not loading new files

* Add serverside protection against a rare bug where the client sends the same file twice for a single post

* Refactored the important parts of uploadFile api call into a function that can be called without a web context

1 files changed, 0 insertions, 148 deletions

diff --git a/api/post_benchmark_test.go b/api/post_benchmark_test.go
deleted file mode 100644
index 5424bc1dd..000000000
--- a/api/post_benchmark_test.go
+++ /dev/null
@@ -1,148 +0,0 @@
-// Copyright (c) 2015 Mattermost, Inc. All Rights Reserved.
-// See License.txt for license information.
-
-package api
-
-import (
-	"github.com/mattermost/platform/utils"
-	"testing"
-)
-
-const (
-	NUM_POSTS = 100
-)
-
-func BenchmarkCreatePost(b *testing.B) {
-	var (
-		NUM_POSTS_RANGE = utils.Range{NUM_POSTS, NUM_POSTS}
-	)
-
-	th := Setup().InitBasic()
-	Client := th.BasicClient
-	channel := th.BasicChannel
-
-	testPoster := NewAutoPostCreator(Client, channel.Id)
-
-	// Benchmark Start
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
-		testPoster.CreateTestPosts(NUM_POSTS_RANGE)
-	}
-}
-
-func BenchmarkUpdatePost(b *testing.B) {
-	var (
-		NUM_POSTS_RANGE = utils.Range{NUM_POSTS, NUM_POSTS}
-		UPDATE_POST_LEN = 100
-	)
-
-	th := Setup().InitBasic()
-	Client := th.BasicClient
-	channel := th.BasicChannel
-
-	testPoster := NewAutoPostCreator(Client, channel.Id)
-	posts, valid := testPoster.CreateTestPosts(NUM_POSTS_RANGE)
-	if valid == false {
-		b.Fatal("Unable to create test posts")
-	}
-
-	for i := range posts {
-		posts[i].Message = utils.RandString(UPDATE_POST_LEN, utils.ALPHANUMERIC)
-	}
-
-	// Benchmark Start
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
-		for i := range posts {
-			if _, err := Client.UpdatePost(posts[i]); err != nil {
-				b.Fatal(err)
-			}
-		}
-	}
-}
-
-func BenchmarkGetPosts(b *testing.B) {
-	var (
-		NUM_POSTS_RANGE = utils.Range{NUM_POSTS, NUM_POSTS}
-	)
-
-	th := Setup().InitBasic()
-	Client := th.BasicClient
-	channel := th.BasicChannel
-
-	testPoster := NewAutoPostCreator(Client, channel.Id)
-	testPoster.CreateTestPosts(NUM_POSTS_RANGE)
-
-	// Benchmark Start
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
-		Client.Must(Client.GetPosts(channel.Id, 0, NUM_POSTS, ""))
-	}
-}
-
-func BenchmarkSearchPosts(b *testing.B) {
-	var (
-		NUM_POSTS_RANGE = utils.Range{NUM_POSTS, NUM_POSTS}
-	)
-
-	th := Setup().InitBasic()
-	Client := th.BasicClient
-	channel := th.BasicChannel
-
-	testPoster := NewAutoPostCreator(Client, channel.Id)
-	testPoster.CreateTestPosts(NUM_POSTS_RANGE)
-
-	// Benchmark Start
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
-		Client.Must(Client.SearchPosts("nothere", false))
-		Client.Must(Client.SearchPosts("n", false))
-		Client.Must(Client.SearchPosts("#tag", false))
-	}
-}
-
-func BenchmarkEtagCache(b *testing.B) {
-	var (
-		NUM_POSTS_RANGE = utils.Range{NUM_POSTS, NUM_POSTS}
-	)
-
-	th := Setup().InitBasic()
-	Client := th.BasicClient
-	channel := th.BasicChannel
-
-	testPoster := NewAutoPostCreator(Client, channel.Id)
-	testPoster.CreateTestPosts(NUM_POSTS_RANGE)
-
-	etag := Client.Must(Client.GetPosts(channel.Id, 0, NUM_POSTS/2, "")).Etag
-
-	// Benchmark Start
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
-		Client.Must(Client.GetPosts(channel.Id, 0, NUM_POSTS/2, etag))
-	}
-}
-
-func BenchmarkDeletePosts(b *testing.B) {
-	var (
-		NUM_POSTS_RANGE = utils.Range{NUM_POSTS, NUM_POSTS}
-	)
-
-	th := Setup().InitBasic()
-	Client := th.BasicClient
-	channel := th.BasicChannel
-
-	testPoster := NewAutoPostCreator(Client, channel.Id)
-	posts, valid := testPoster.CreateTestPosts(NUM_POSTS_RANGE)
-	if valid == false {
-		b.Fatal("Unable to create test posts")
-	}
-
-	// Benchmark Start
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
-		for i := range posts {
-			Client.Must(Client.DeletePost(channel.Id, posts[i].Id))
-		}
-	}
-
-}