diff options
author | Maxim <mail@potapovmax.com> | 2015-10-13 10:15:44 +0300 |
---|---|---|
committer | Maxim <mail@potapovmax.com> | 2015-10-13 10:15:44 +0300 |
commit | 9d3248ccec89e533527bb86e082ef445c3cdfe7d (patch) | |
tree | fea41f942c66a2ae397ed12f1013585bcbf7775c /doc/developer/Code-Contribution-Guidelines.md | |
parent | 53d58fc3374268484a6eb5d8aae2c82719ec782d (diff) | |
parent | 0144b6fd8a95c6b65695b07483a528707dce1cfe (diff) | |
download | chat-9d3248ccec89e533527bb86e082ef445c3cdfe7d.tar.gz chat-9d3248ccec89e533527bb86e082ef445c3cdfe7d.tar.bz2 chat-9d3248ccec89e533527bb86e082ef445c3cdfe7d.zip |
Merge branch 'master' into PLT-590
Diffstat (limited to 'doc/developer/Code-Contribution-Guidelines.md')
-rw-r--r-- | doc/developer/Code-Contribution-Guidelines.md | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/doc/developer/Code-Contribution-Guidelines.md b/doc/developer/Code-Contribution-Guidelines.md index 80676f107..453c154f9 100644 --- a/doc/developer/Code-Contribution-Guidelines.md +++ b/doc/developer/Code-Contribution-Guidelines.md @@ -5,7 +5,6 @@ Thank you for your interest in contributing to Mattermost. This guide provides a ## Choose a Ticket 1. Review the list of [Good First Contribution](https://mattermost.atlassian.net/issues/?filter=10206) tickets listed in Jira. - 2. These projects are intended to be a straight forward first pull requests from new contributors. If you don't find something appropriate for your interests, please see the full list of tickets [Accepting Pull Requests](https://mattermost.atlassian.net/issues/?filter=10101). @@ -13,7 +12,7 @@ If you don't find something appropriate for your interests, please see the full ## Install Mattermost and set up a Fork -1. Follow [developer setup instructions](https://github.com/mattermost/platform/blob/master/doc/install/dev-setup.md) to install Mattermost. +1. Follow [developer setup instructions](https://github.com/mattermost/platform/blob/master/doc/developer/Setup.md) to install Mattermost. 2. Create a branch with <branch name> set to the ID of the ticket you're working on, for example ```PLT-394```, using command: @@ -29,6 +28,9 @@ git checkout -b <branch name> 2. Please make sure to thoroughly test your change before submitting a pull request. + Please review the ["Fast, Obvious, Forgiving" experience design principles](http://www.mattermost.org/design-principles/) for Mattermost and check that your feature meets the criteria. Also, for any changes to user interface or help text, please read the changes out loud, as a quick and easy way to catch any inconsitencies. + + ## Submitting a Pull Request 1. Please add yourself to the Mattermost [approved contributor list](https://docs.google.com/spreadsheets/d/1NTCeG-iL_VS9bFqtmHSfwETo5f-8MQ7oMDE5IUYJi_Y/pubhtml?gid=0&single=true) prior to submitting by completing the [contributor license agreement](http://www.mattermost.org/mattermost-contributor-agreement/). |