diff options
author | hmhealey <harrisonmhealey@gmail.com> | 2015-11-10 11:54:43 -0500 |
---|---|---|
committer | hmhealey <harrisonmhealey@gmail.com> | 2015-11-17 11:04:31 -0500 |
commit | 590e7f903f3b911566465b2fb51ff68c273ded96 (patch) | |
tree | 02ac280ef7b2afd8508f548b4df7a99eb79adc99 /web/react/components | |
parent | 9cdf820f7b154b312d5022fec20754141b0d8476 (diff) | |
download | chat-590e7f903f3b911566465b2fb51ff68c273ded96.tar.gz chat-590e7f903f3b911566465b2fb51ff68c273ded96.tar.bz2 chat-590e7f903f3b911566465b2fb51ff68c273ded96.zip |
Renamed onModalDismissed to onHide to keep it consistent with React-Bootstrap
Diffstat (limited to 'web/react/components')
-rw-r--r-- | web/react/components/access_history_modal.jsx | 5 | ||||
-rw-r--r-- | web/react/components/activity_log_modal.jsx | 6 | ||||
-rw-r--r-- | web/react/components/toggle_modal_button.jsx | 26 |
3 files changed, 19 insertions, 18 deletions
diff --git a/web/react/components/access_history_modal.jsx b/web/react/components/access_history_modal.jsx index 6a10f87b2..8306a4e8c 100644 --- a/web/react/components/access_history_modal.jsx +++ b/web/react/components/access_history_modal.jsx @@ -14,6 +14,7 @@ export default class AccessHistoryModal extends React.Component { this.onAuditChange = this.onAuditChange.bind(this); this.handleMoreInfo = this.handleMoreInfo.bind(this); + this.onShow = this.onShow.bind(this); this.onHide = this.onHide.bind(this); this.formatAuditInfo = this.formatAuditInfo.bind(this); this.handleRevokedSession = this.handleRevokedSession.bind(this); @@ -38,7 +39,7 @@ export default class AccessHistoryModal extends React.Component { } onHide() { this.setState({moreInfo: []}); - this.props.onModalDismissed(); + this.props.onHide(); } componentDidMount() { UserStore.addAuditsChangeListener(this.onAuditChange); @@ -401,5 +402,5 @@ export default class AccessHistoryModal extends React.Component { AccessHistoryModal.propTypes = { show: React.PropTypes.bool.isRequired, - onModalDismissed: React.PropTypes.func.isRequired + onHide: React.PropTypes.func.isRequired }; diff --git a/web/react/components/activity_log_modal.jsx b/web/react/components/activity_log_modal.jsx index 6c329d416..5c385c93d 100644 --- a/web/react/components/activity_log_modal.jsx +++ b/web/react/components/activity_log_modal.jsx @@ -4,7 +4,7 @@ const UserStore = require('../stores/user_store.jsx'); const Client = require('../utils/client.jsx'); const AsyncClient = require('../utils/async_client.jsx'); -const Modal = ReactBootstrap.Modal; +const Modal = require('./modal.jsx'); const LoadingScreen = require('./loading_screen.jsx'); const Utils = require('../utils/utils.jsx'); @@ -58,7 +58,7 @@ export default class ActivityLogModal extends React.Component { } onHide() { this.setState({moreInfo: []}); - this.props.onModalDismissed(); + this.props.onHide(); } componentDidMount() { UserStore.addSessionsChangeListener(this.onListenerChange); @@ -174,5 +174,5 @@ export default class ActivityLogModal extends React.Component { ActivityLogModal.propTypes = { show: React.PropTypes.bool.isRequired, - onModalDismissed: React.PropTypes.func.isRequired + onHide: React.PropTypes.func.isRequired }; diff --git a/web/react/components/toggle_modal_button.jsx b/web/react/components/toggle_modal_button.jsx index 86ee439a5..51c8d1f20 100644 --- a/web/react/components/toggle_modal_button.jsx +++ b/web/react/components/toggle_modal_button.jsx @@ -24,29 +24,29 @@ export default class ModalToggleButton extends React.Component { render() { const {children, dialogType, dialogProps, ...props} = this.props; - // this assumes that all modals will have a show property and an onModalDismissed event + // this assumes that all modals will have a show property and an onHide event const dialog = React.createElement(this.props.dialogType, Object.assign({}, dialogProps, { show: this.state.show, - onModalDismissed: () => { + onHide: () => { this.hide(); - if (dialogProps.onModalDismissed) { - dialogProps.onModalDismissed(); + if (dialogProps.onHide) { + dialogProps.onHide(); } } })); + // nesting the dialog in the anchor tag looks like it shouldn't work, but it does due to how react-bootstrap + // renders modals at the top level of the DOM instead of where you specify in the virtual DOM return ( - <div style={{display: 'inline'}}> - <a - {...props} - href='#' - onClick={this.show} - > - {children} - </a> + <a + {...props} + href='#' + onClick={this.show} + > + {children} {dialog} - </div> + </a> ); } } |