diff options
| author | Harrison Healey <harrisonmhealey@gmail.com> | 2016-11-21 12:17:46 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2016-11-21 12:17:46 -0500 |
| commit | a9824a3653a30779f7fd0cc62e329c988f02b519 (patch) | |
| tree | 47689539ae8a5d53b968d8746fa412c2609a9ac5 /webapp/actions | |
| parent | 477dc6c4b62aad9102cb2c86f1d722ea996270d5 (diff) | |
| download | chat-a9824a3653a30779f7fd0cc62e329c988f02b519.tar.gz chat-a9824a3653a30779f7fd0cc62e329c988f02b519.tar.bz2 chat-a9824a3653a30779f7fd0cc62e329c988f02b519.zip | |
Hotfix: PLT-4779 Fixing scrolling on loading a channel and missing DM channel headers (#4584)
* Added all parameters to call tracker ids when getting profiles
* Changed channel header rendering to not depend on knowing all users in a DM channel
* Added comment about a race condition in UserActions.populateDMChannelsWithProfiles
* Added a fixed-height placeholder for the ChannelHeader when its state isn't valid for rendering
Diffstat (limited to 'webapp/actions')
| -rw-r--r-- | webapp/actions/user_actions.jsx | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/webapp/actions/user_actions.jsx b/webapp/actions/user_actions.jsx index 304d36a62..9b5bc985c 100644 --- a/webapp/actions/user_actions.jsx +++ b/webapp/actions/user_actions.jsx @@ -135,6 +135,7 @@ function populateDMChannelsWithProfiles(userIds) { const currentUserId = UserStore.getCurrentId(); for (let i = 0; i < userIds.length; i++) { + // TODO There's a race condition here for DM channels if those channels aren't loaded yet const channelName = getDirectChannelName(currentUserId, userIds[i]); const channel = ChannelStore.getByName(channelName); if (channel) { |