Updating ESLint (#4085)

5 files changed, 28 insertions, 34 deletions

diff --git a/webapp/components/user_settings/custom_theme_chooser.jsx b/webapp/components/user_settings/custom_theme_chooser.jsx
index 016751faa..148996293 100644
--- a/webapp/components/user_settings/custom_theme_chooser.jsx
+++ b/webapp/components/user_settings/custom_theme_chooser.jsx
@@ -286,7 +286,7 @@ class CustomThemeChooser extends React.Component {
                                 type='text'
                                 defaultValue={theme[element.id]}
                             />
-                            <span className='input-group-addon'><i></i></span>
+                            <span className='input-group-addon'><i/></span>
                         </div>
                     </div>
                 );
@@ -308,7 +308,7 @@ class CustomThemeChooser extends React.Component {
                                 type='text'
                                 defaultValue={theme[element.id]}
                             />
-                            <span className='input-group-addon'><i></i></span>
+                            <span className='input-group-addon'><i/></span>
                         </div>
                     </div>
                 );
@@ -330,7 +330,7 @@ class CustomThemeChooser extends React.Component {
                                 type='text'
                                 defaultValue={theme[element.id]}
                             />
-                            <span className='input-group-addon'><i></i></span>
+                            <span className='input-group-addon'><i/></span>
                         </div>
                     </div>
                 );
@@ -370,8 +370,8 @@ class CustomThemeChooser extends React.Component {
                             defaultMessage='Sidebar Styles'
                         />
                         <div className='header__icon'>
-                            <i className='fa fa-plus'></i>
-                            <i className='fa fa-minus'></i>
+                            <i className='fa fa-plus'/>
+                            <i className='fa fa-minus'/>
                         </div>
                     </div>
                     <div className='theme-elements__body'>
@@ -388,8 +388,8 @@ class CustomThemeChooser extends React.Component {
                             defaultMessage='Center Channel Styles'
                         />
                         <div className='header__icon'>
-                            <i className='fa fa-plus'></i>
-                            <i className='fa fa-minus'></i>
+                            <i className='fa fa-plus'/>
+                            <i className='fa fa-minus'/>
                         </div>
                     </div>
                     <div className='theme-elements__body'>
@@ -406,8 +406,8 @@ class CustomThemeChooser extends React.Component {
                             defaultMessage='Link and Button Styles'
                         />
                         <div className='header__icon'>
-                            <i className='fa fa-plus'></i>
-                            <i className='fa fa-minus'></i>
+                            <i className='fa fa-plus'/>
+                            <i className='fa fa-minus'/>
                         </div>
                     </div>
                     <div className='theme-elements__body'>
diff --git a/webapp/components/user_settings/desktop_notification_settings.jsx b/webapp/components/user_settings/desktop_notification_settings.jsx
index e5376c7ee..109212049 100644
--- a/webapp/components/user_settings/desktop_notification_settings.jsx
+++ b/webapp/components/user_settings/desktop_notification_settings.jsx
@@ -21,7 +21,7 @@ export default class DesktopNotificationSettings extends React.Component {
     }
 
     buildMaximizedSetting() {
-        let inputs = [];
+        const inputs = [];
         let extraInfo = null;
 
         const activityRadio = [false, false, false];
diff --git a/webapp/components/user_settings/user_settings_notifications.jsx b/webapp/components/user_settings/user_settings_notifications.jsx
index 05881dcf9..35df53e0e 100644
--- a/webapp/components/user_settings/user_settings_notifications.jsx
+++ b/webapp/components/user_settings/user_settings_notifications.jsx
@@ -260,9 +260,8 @@ export default class NotificationsTab extends React.Component {
     }
 
     createPushNotificationSection() {
-        let handleUpdatePushSection;
         if (this.props.activeSection === 'push') {
-            let inputs = [];
+            const inputs = [];
             let extraInfo = null;
             let submit = null;
 
@@ -508,9 +507,9 @@ export default class NotificationsTab extends React.Component {
             }
         }
 
-        handleUpdatePushSection = function updateDesktopSection() {
+        const handleUpdatePushSection = () => {
             this.props.updateSection('push');
-        }.bind(this);
+        };
 
         return (
             <SettingItemMin
@@ -528,17 +527,12 @@ export default class NotificationsTab extends React.Component {
         var keysSection;
         var handleUpdateKeysSection;
         if (this.props.activeSection === 'keys') {
-            let inputs = [];
-
-            let handleUpdateFirstNameKey;
-            let handleUpdateUsernameKey;
-            let handleUpdateMentionKey;
-            let handleUpdateChannelKey;
+            const inputs = [];
 
             if (user.first_name) {
-                handleUpdateFirstNameKey = function handleFirstNameKeyChange(e) {
+                const handleUpdateFirstNameKey = (e) => {
                     this.updateFirstNameKey(e.target.checked);
-                }.bind(this);
+                };
                 inputs.push(
                     <div key='userNotificationFirstNameOption'>
                         <div className='checkbox'>
@@ -561,9 +555,9 @@ export default class NotificationsTab extends React.Component {
                 );
             }
 
-            handleUpdateUsernameKey = function handleUsernameKeyChange(e) {
+            const handleUpdateUsernameKey = (e) => {
                 this.updateUsernameKey(e.target.checked);
-            }.bind(this);
+            };
             inputs.push(
                 <div key='userNotificationUsernameOption'>
                     <div className='checkbox'>
@@ -585,9 +579,9 @@ export default class NotificationsTab extends React.Component {
                 </div>
             );
 
-            handleUpdateMentionKey = function handleMentionKeyChange(e) {
+            const handleUpdateMentionKey = (e) => {
                 this.updateMentionKey(e.target.checked);
-            }.bind(this);
+            };
             inputs.push(
                 <div key='userNotificationMentionOption'>
                     <div className='checkbox'>
@@ -609,9 +603,9 @@ export default class NotificationsTab extends React.Component {
                 </div>
             );
 
-            handleUpdateChannelKey = function handleChannelKeyChange(e) {
+            const handleUpdateChannelKey = (e) => {
                 this.updateChannelKey(e.target.checked);
-            }.bind(this);
+            };
             inputs.push(
                 <div key='userNotificationChannelOption'>
                     <div className='checkbox'>
@@ -728,7 +722,7 @@ export default class NotificationsTab extends React.Component {
                 commentsActive[0] = true;
             }
 
-            let inputs = [];
+            const inputs = [];
 
             inputs.push(
                 <div key='userNotificationLevelOption'>
diff --git a/webapp/components/user_settings/user_settings_security.jsx b/webapp/components/user_settings/user_settings_security.jsx
index 5bc29e0df..3cff93a0f 100644
--- a/webapp/components/user_settings/user_settings_security.jsx
+++ b/webapp/components/user_settings/user_settings_security.jsx
@@ -971,23 +971,23 @@ export default class SecurityTab extends React.Component {
                     <div className='divider-light'/>
                     {signInSection}
                     <div className='divider-dark'/>
-                    <br></br>
+                    <br/>
                     <ToggleModalButton
                         className='security-links theme'
                         dialogType={AccessHistoryModal}
                     >
-                        <i className='fa fa-clock-o'></i>
+                        <i className='fa fa-clock-o'/>
                         <FormattedMessage
                             id='user.settings.security.viewHistory'
                             defaultMessage='View Access History'
                         />
                     </ToggleModalButton>
-                    <b> </b>
+                    <b/>
                     <ToggleModalButton
                         className='security-links theme'
                         dialogType={ActivityLogModal}
                     >
-                        <i className='fa fa-clock-o'></i>
+                        <i className='fa fa-clock-o'/>
                         <FormattedMessage
                             id='user.settings.security.logoutActiveSessions'
                             defaultMessage='View and Logout of Active Sessions'
diff --git a/webapp/components/user_settings/user_settings_theme.jsx b/webapp/components/user_settings/user_settings_theme.jsx
index d12a7689a..f1bed0085 100644
--- a/webapp/components/user_settings/user_settings_theme.jsx
+++ b/webapp/components/user_settings/user_settings_theme.jsx
@@ -209,7 +209,7 @@ export default class ThemeSetting extends React.Component {
 
         let themeUI;
         if (this.props.selected) {
-            let inputs = [];
+            const inputs = [];
 
             inputs.push(
                 <div