summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNico <paetni1@gmail.com>2020-07-19 19:57:23 +0200
committerNico <paetni1@gmail.com>2020-07-19 19:57:23 +0200
commit19acd7861d1843460297f27e8da0c90dba6ebe54 (patch)
treeea3c0a4ba35f9af26d06ff9c68c453258be975fa
parent282f0f91fef799dc3981004e4d20730ae18eff2f (diff)
downloadwekan-19acd7861d1843460297f27e8da0c90dba6ebe54.tar.gz
wekan-19acd7861d1843460297f27e8da0c90dba6ebe54.tar.bz2
wekan-19acd7861d1843460297f27e8da0c90dba6ebe54.zip
Change slug on card rename
-rw-r--r--models/boards.js12
1 files changed, 4 insertions, 8 deletions
diff --git a/models/boards.js b/models/boards.js
index f272e097..306bae13 100644
--- a/models/boards.js
+++ b/models/boards.js
@@ -18,18 +18,14 @@ Boards.attachSchema(
type: String,
// eslint-disable-next-line consistent-return
autoValue() {
- // XXX We need to improve slug management. Only the id should be necessary
- // to identify a board in the code.
- // XXX If the board title is updated, the slug should also be updated.
// In some cases (Chinese and Japanese for instance) the `getSlug` function
// return an empty string. This is causes bugs in our application so we set
// a default slug in this case.
- if (this.isInsert && !this.isSet) {
+ // Improvment would be to change client URL after slug is changed
+ const title = this.field('title');
+ if (title.isSet && !this.isSet) {
let slug = 'board';
- const title = this.field('title');
- if (title.isSet) {
- slug = getSlug(title.value) || slug;
- }
+ slug = getSlug(title.value) || slug;
return slug;
}
},