summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLauri Ojansivu <x@xet7.org>2020-05-14 01:04:52 +0300
committerLauri Ojansivu <x@xet7.org>2020-05-14 01:04:52 +0300
commitea74a34d72fb0f33909858a640dbcd3a5fda5b7f (patch)
tree697e686168f41fef0da5903722bbda98e17d0ff0
parent28cffc43287d154ff4dafc78766401449fb13746 (diff)
downloadwekan-ea74a34d72fb0f33909858a640dbcd3a5fda5b7f.tar.gz
wekan-ea74a34d72fb0f33909858a640dbcd3a5fda5b7f.tar.bz2
wekan-ea74a34d72fb0f33909858a640dbcd3a5fda5b7f.zip
Add popup and changelog for linked card fixes.
-rw-r--r--CHANGELOG.md2
-rw-r--r--client/components/cards/cardDetails.js13
-rw-r--r--client/components/lists/listHeader.js12
3 files changed, 25 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index ce9860b3..c90ff173 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -27,6 +27,8 @@ and adds the following translations:
and fixes the following bugs:
+- [Fix Deleting linked card makes board not load](https://github.com/wekan/wekan/issues/2785).
+ Thanks to marc1006 and xet7.
- [Fix getStartDayOfWeek once again](https://github.com/wekan/wekan/pull/3061).
Thanks to marc1006.
- [Fix shortcuts list and support card shortcuts when hovering
diff --git a/client/components/cards/cardDetails.js b/client/components/cards/cardDetails.js
index 048a7e1a..441068b0 100644
--- a/client/components/cards/cardDetails.js
+++ b/client/components/cards/cardDetails.js
@@ -960,7 +960,18 @@ BlazeComponent.extendComponent({
if (Cards.find({ linkedId: this._id }).count() === 0) {
Cards.remove(this._id);
} else {
- // TODO popup...
+ // TODO: Maybe later we can list where the linked cards are.
+ // Now here is popup with a hint that the card cannot be deleted
+ // as there are linked cards.
+ // Related:
+ // client/components/lists/listHeader.js about line 248
+ // https://github.com/wekan/wekan/issues/2785
+ const message = `${TAPi18n.__(
+ 'delete-linked-card-before-this-card',
+ )} linkedId: ${
+ this._id
+ } at client/components/cards/cardDetails.js and https://github.com/wekan/wekan/issues/2785`;
+ alert(message);
}
Utils.goBoardId(this.boardId);
}),
diff --git a/client/components/lists/listHeader.js b/client/components/lists/listHeader.js
index a839bb72..7cd4309f 100644
--- a/client/components/lists/listHeader.js
+++ b/client/components/lists/listHeader.js
@@ -238,9 +238,19 @@ Template.listMorePopup.events({
allCardIds.map(_id => Cards.remove(_id));
Lists.remove(this._id);
} else {
- // TODO popup with a hint that the list cannot be deleted as there are
+ // TODO: Figure out more informative message.
+ // Popup with a hint that the list cannot be deleted as there are
// linked cards. We can adapt the query above so we can list the linked
// cards.
+ // Related:
+ // client/components/cards/cardDetails.js about line 969
+ // https://github.com/wekan/wekan/issues/2785
+ const message = `${TAPi18n.__(
+ 'delete-linked-cards-before-this-list',
+ )} linkedId: ${
+ this._id
+ } at client/components/lists/listHeader.js and https://github.com/wekan/wekan/issues/2785`;
+ alert(message);
}
Utils.goBoardId(this.boardId);
}),