diff options
author | Romulus Tsai 蔡仲明 <urakagi@gmail.com> | 2020-05-14 16:45:21 +0800 |
---|---|---|
committer | Romulus Tsai 蔡仲明 <urakagi@gmail.com> | 2020-05-14 16:45:21 +0800 |
commit | 5d8cca40d217b6a3895f1f6eb154b6aba9576b37 (patch) | |
tree | 697e686168f41fef0da5903722bbda98e17d0ff0 /client/components/lists/listHeader.js | |
parent | cfcc73724fcd394150d1b815d0a7a4c466e216b5 (diff) | |
parent | 9c6cd51ca720502cc993451505f95a43ef16a707 (diff) | |
download | wekan-5d8cca40d217b6a3895f1f6eb154b6aba9576b37.tar.gz wekan-5d8cca40d217b6a3895f1f6eb154b6aba9576b37.tar.bz2 wekan-5d8cca40d217b6a3895f1f6eb154b6aba9576b37.zip |
Merge branch 'master' of https://github.com/wekan/wekan
Diffstat (limited to 'client/components/lists/listHeader.js')
-rw-r--r-- | client/components/lists/listHeader.js | 31 |
1 files changed, 29 insertions, 2 deletions
diff --git a/client/components/lists/listHeader.js b/client/components/lists/listHeader.js index 46dbd748..7cd4309f 100644 --- a/client/components/lists/listHeader.js +++ b/client/components/lists/listHeader.js @@ -223,8 +223,35 @@ BlazeComponent.extendComponent({ Template.listMorePopup.events({ 'click .js-delete': Popup.afterConfirm('listDelete', function() { Popup.close(); - this.allCards().map(card => Cards.remove(card._id)); - Lists.remove(this._id); + // TODO how can we avoid the fetch call? + const allCards = this.allCards().fetch(); + const allCardIds = _.pluck(allCards, '_id'); + // it's okay if the linked cards are on the same list + if ( + Cards.find({ + $and: [ + { listId: { $ne: this._id } }, + { linkedId: { $in: allCardIds } }, + ], + }).count() === 0 + ) { + allCardIds.map(_id => Cards.remove(_id)); + Lists.remove(this._id); + } else { + // TODO: Figure out more informative message. + // Popup with a hint that the list cannot be deleted as there are + // linked cards. We can adapt the query above so we can list the linked + // cards. + // Related: + // client/components/cards/cardDetails.js about line 969 + // https://github.com/wekan/wekan/issues/2785 + const message = `${TAPi18n.__( + 'delete-linked-cards-before-this-list', + )} linkedId: ${ + this._id + } at client/components/lists/listHeader.js and https://github.com/wekan/wekan/issues/2785`; + alert(message); + } Utils.goBoardId(this.boardId); }), }); |