summaryrefslogtreecommitdiffstats
path: root/client/components/swimlanes
diff options
context:
space:
mode:
authorMarc Hartmayer <hello@hartmayer.com>2020-04-23 02:09:01 +0200
committerMarc Hartmayer <hello@hartmayer.com>2020-04-23 03:02:03 +0200
commit6476503137fc41cf52e913aa33aed6bb1abaac6a (patch)
tree2e578e709706934e908af36c3cb1bdb4f68b9848 /client/components/swimlanes
parent981ed546f1cae45ad8b92b393ee29c1a26277f32 (diff)
downloadwekan-6476503137fc41cf52e913aa33aed6bb1abaac6a.tar.gz
wekan-6476503137fc41cf52e913aa33aed6bb1abaac6a.tar.bz2
wekan-6476503137fc41cf52e913aa33aed6bb1abaac6a.zip
Fix drag-and-drop and scrolling on mobile devices
Use drag handles on "miniscreens" whenever useful, this is especially useful on mobile device. This should hopefully fix https://github.com/wekan/wekan/issues/2947. While at it, simplify the condition Utils.isMiniScreen() || (!Utils.isMiniScreen() && showDesktopDragHandles) to Utils.isMiniScreen() || showDesktopDragHandle
Diffstat (limited to 'client/components/swimlanes')
-rw-r--r--client/components/swimlanes/swimlanes.js9
1 files changed, 4 insertions, 5 deletions
diff --git a/client/components/swimlanes/swimlanes.js b/client/components/swimlanes/swimlanes.js
index 577bf6d2..2d299ddc 100644
--- a/client/components/swimlanes/swimlanes.js
+++ b/client/components/swimlanes/swimlanes.js
@@ -111,7 +111,7 @@ function initSortable(boardComponent, $listsDom) {
showDesktopDragHandles = false;
}
- if (!Utils.isMiniScreen() && showDesktopDragHandles) {
+ if (Utils.isMiniScreen() || showDesktopDragHandles) {
$listsDom.sortable({
handle: '.js-list-handle',
});
@@ -126,8 +126,8 @@ function initSortable(boardComponent, $listsDom) {
$listsDom.sortable(
'option',
'disabled',
- // Disable drag-dropping when user is not member/is worker/is miniscreen
- !userIsMember() || Meteor.user().isWorker() || Utils.isMiniScreen(),
+ // Disable drag-dropping when user is not member/is worker
+ !userIsMember() || Meteor.user().isWorker(),
// Not disable drag-dropping while in multi-selection mode
// MultiSelection.isActive() || !userIsMember(),
);
@@ -188,8 +188,7 @@ BlazeComponent.extendComponent({
}
const noDragInside = ['a', 'input', 'textarea', 'p'].concat(
- Utils.isMiniScreen() ||
- (!Utils.isMiniScreen() && showDesktopDragHandles)
+ Utils.isMiniScreen() || showDesktopDragHandles
? ['.js-list-handle', '.js-swimlane-header-handle']
: ['.js-list-header'],
);